summaryrefslogtreecommitdiffstats
path: root/tmk_core
Commit message (Collapse)AuthorAgeFilesLines
* Revert changes to ChibiOS Suspend Code (#21830)Drashna Jaelre2023-08-272-22/+56
| | | | | | | | | | | | | | | | | | | | | * Partially revert #19780 * Finish * Get teensy 3.5/3.6 board files too * fix lint issue * Revert "[Bug] Restore usb suspend wakeup delay (#21676)" This reverts commit e8e989fd7ad7c10e725e50ae8b0a4426e09f7f30. * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> --------- Co-authored-by: Joel Challis <git@zvecr.com>
* [Bug] Restore usb suspend wakeup delay (#21676)Stefan Kerkmann2023-08-022-44/+14
| | | | | | | | | * Respect USB_SUSPEND_WAKEUP_DELAY on wakeup This delay wasn't honored after removing `restart_usb_driver` from the suspend and wakeup handling. It is now re-introduced in the appropriate spot, namely after issuing a remote wakeup to a sleeping host. * Remove old, unused and commented testing code
* Fix mouse-key spamming empty reports (#21663)Stefan Kerkmann2023-08-021-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | Problem: `mousekey_task` spams empty hid reports with when a mouse key is pressed, causing resource exhaustion in the USB mouse endpoint. Cause: The check whether or not to send a new mouse report would always evaluate to true if a mouse key is pressed: 1. `mouse_report` has non-zero fields and `tmpmr` is a copy of this fields. 2. `mouse_report` is set to zero, `tmpmr` has now non-zero fields. 3. `has_mouse_report_changed` compares the two and evaluates to true 4. a mouse report is sent. Fix: The check condition of `has_mouse_report_changed` will evaluate any empty record as unchanged, as mouse report data is relative and doesn't need to return to zero. An empty report will still be send by `register_mouse` on release of all mouse buttons.
* Update keyboard report descriptor for USB compliance (#21626)Stefan Kerkmann2023-07-282-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Running the "HID Tests" suite of the USB 3 Command Verifier (USB3CV) tool resulted in the following error: (HID: 3.2.61) The report descriptor returned in response to a GetDescriptor(Report) must be compliant with the HID specification. Byte Number: 37h ( 55d) Data Field: 91 02 Mnemonic: Output Value: (Variable) Errors: Error: LOGICAL MAX MUST be bounded by Report Size The error stems from the fact that logical minimum and maximum are global items, which means that the next item in a report descriptor inherits the value from the previously set value. In this case the status leds item inherited the logical minimum (=0) and maximum (=255) from the keycodes item. As the status leds set a report size of 1 bit, wich can only hold a boolean, it becomes clear that this range would never fit. The fix is straightforward, we just define a appropriate logical maximum (=1), the mismatch is solved and our keyboard now passes the compliance tests. Defining the logical minimum is redundant in this case but is kept to form a logical block.
* quantum: remove direct `quantum.h` includes (#21507)Ryan2023-07-163-0/+4
|
* Eliminate `TMK_COMMON_*` in makefiles (#21517)Ryan2023-07-151-20/+20
|
* tmk_core: remove direct `quantum.h` includes (#21465)Ryan2023-07-077-9/+13
|
* Get rid of `USB_LED_KANA` and `USB_LED_COMPOSE` (#21366)Ryan2023-06-271-7/+7
|
* [Bug] Fix non-functional S3 wakeup / resume from suspense (#19780)Stefan Kerkmann2023-06-262-14/+10
| | | | | | | | | | | | | | | | | | | | * Update ChibiOS-Contrib for USB suspend fixes * Remove S3 wakup workaround ChibiOS OTGv1 driver has a remote wakeup bug that prevents the device to resume it's operation. 02516cbc24647f522eee975e69cc0c8a925470eb introduced a hotfix that forcefully restarted the usb driver as a workaround. This workaround broke multiple boards which do not use this driver / peripheral. With the update of ChibiOS this hotfix is now obsolete. * Remove restart_usb_driver overrides they are no longer necessary as the workaround is not needed anymore for stm32f4 * Remove unused RP_USB_USE_SOF_INTR defines The SOF interrupt is enabled dynamically by the RP2040 usb driver
* Chibios USB: Take into account if host wants remote wakeup or not (#21287)Purdea Andrei2023-06-261-1/+3
| | | | | | | | | | | | | | | According to the USB 2.0 spec, remote wakeup should be disabled by default, and should only be enabled if the host explicitly requests it. The chibios driver code already takes care of storing this information, and returning it on GET_STATUS requests. However our application code has been ignoring it so far. This is a USB compliance issue, but also a bug that causes trouble in some cases: On RP2040 targets this has been causing problems if a key is held down while the keyboard is plugged in. The keyboard would fail to enumerate until all keys are released. With this change that behavior is fixed. Note that for LUFA targets this is already done correctly.
* Move protocol makefiles into their respective folders (#21332)Ryan2023-06-226-1/+1
| | | | | * Move protocol makefiles into their respective folders * Fix USB-USB converter
* Disable specific warnings to mitigate compilation problems with ↵Nick Brassel2023-04-051-3/+3
| | | | `KEEP_INTERMEDIATES=yes`. (#20339)
* Move `KC_MISSION_CONTROL`/`KC_LAUNCHPAD` keycodes to core (#19884)Joel Challis2023-02-191-1/+7
|
* Remove `IS_HOST_LED_ON` and migrate usages (#19753)Ryan2023-02-061-3/+0
|
* Fix midi after recent refactoring (#19723)Joel Challis2023-01-311-0/+4
|
* Move MIDI code out of tmk_core (#19704)Ryan2023-01-3018-2525/+0
|
* Fix functions with empty params (#19647)Ryan2023-01-201-2/+2
| | | | | * Fix functions with empty params * Found a bunch more
* ChibiOS: Consolidate report sending code (#19607)Ryan2023-01-161-151/+40
|
* Fix joystick build for ChibiOS (#19602)Sergey Vlasov2023-01-151-1/+1
| | | | `joystick_report_t` was renamed to `report_joystick_t`, but apparently one place in the code was missed.
* usb_main.c: remove `CH_KERNEL_MAJOR` check (#19597)Ryan2023-01-151-8/+0
|
* [CI] Format code according to conventions (#19265)QMK Bot2022-12-091-9/+9
|
* Return USB HID GET_REPORT requests (#14814)Jack Humbert2022-12-091-12/+43
| | | | Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Nick Brassel <nick@tzarc.org>
* Detect host OS based on USB fingerprint (#18463)Ruslan Sayfutdinov2022-12-095-7/+23
| | | | Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Nick Brassel <nick@tzarc.org>
* Fixed NKRO issue caused by HID_SET_PROTOCOL on Chibios platform (#17588)lokher2022-12-091-2/+1
|
* Revert WB32 ISO workaround (#19224)Joel Challis2022-12-031-3/+0
|
* Joystick feature improvements (#19052)Ryan2022-11-2710-95/+198
|
* Digitizer feature improvements (#19034)Ryan2022-11-124-43/+41
|
* ChibiOS USB: Add a dummy IN callback to work around LLD bugs (#18811)Sergey Vlasov2022-10-221-5/+15
| | | | | | | | | | | | | | | | In #18631 some IN notification callbacks that were doing nothing were removed, which should be a valid thing to do (ChibiOS HAL checks the `in_cb` and `out_cb` pointers for being non-NULL before invoking those optional callbacks). However, it turned out that some less popular USB LLDs (KINETIS and MIMXRT1062) have their own checks for those pointers, and (incorrectly) skip the ChibiOS callback handling when those pointers are NULL, which breaks the code for the `USB_USE_WAIT` configuration option (the waiting thread never gets resumed if the corresponding callback pointer is NULL). Add those dummy callbacks again (but use a single function for all of them instead of individual ones for each endpoint); this restores the KINETIS and MIMXRT1062 boards to the working state while the LLDs are getting fixed.
* Widen the ARM Cortex-M family support. Allow USB peripheral change. (#18767)Nick Brassel2022-10-192-4/+7
|
* LUFA: Consolidate report sending code (#18629)Ryan2022-10-151-118/+43
|
* Fix joystick functionality for ChibiOS and OTG (Blackpill) (#18631)Ryan2022-10-133-131/+82
| | | Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
* Make MIDI output endpoint use the out direction (#18654)nezumee2022-10-091-1/+1
|
* Refactor `send_extra` (#18615)Ryan2022-10-0611-84/+50
|
* Refactor more host code (programmable button & digitizer) (#18565)Ryan2022-10-057-50/+30
|
* [Core] ChibiOS: Fix USB bus disconnect handling (#18566)Stefan Kerkmann2022-10-022-1/+3
|
* Start Bluetooth API (#18366)Ryan2022-09-291-21/+4
|
* Further refactoring of joystick feature (#18437)Ryan2022-09-275-100/+64
|
* Chromeos keycodes (#18212)Joshua Diamond2022-09-171-0/+4
|
* Merge remote-tracking branch 'origin/master' into developJoshua Diamond2022-09-121-0/+3
|\
| * GMMK2: Fix 'ISO' within product name (#18322)Joel Challis2022-09-101-0/+3
| |
* | Move Bluetooth-related function calls up to host/keyboard level (#18274)Ryan2022-09-072-51/+43
| | | | | | | | | | | | | | | | | | | | | | * Move Bluetooth-related function calls up to host/keyboard level * Remove pointless set_output() call * Move bluetooth (rn42) init to end of keyboard_init() * Enable SPI/UART for ChibiOS targets * Some more slight tweaks
* | Adjust `EXTRAKEY_ENABLE` ifdefs for `send_extra()` (#18249)Ryan2022-09-024-8/+8
| |
* | Simplify extrakeys sending at the host driver level (#18230)Ryan2022-09-027-79/+18
| | | | | | | | | | | | | | | | | | * Simplify extrakeys sending at the host driver level * There are two arguments here * Wrong syntax * Adjust keyboards which use a custom host driver
* | Use a macro to compute the size of arrays at compile time (#18044)Jeff Epler2022-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ARRAY_SIZE and CEILING utility macros * Apply a coccinelle patch to use ARRAY_SIZE * fix up some straggling items * Fix 'make test:secure' * Enhance ARRAY_SIZE macro to reject acting on pointers The previous definition would not produce a diagnostic for ``` int *p; size_t num_elem = ARRAY_SIZE(p) ``` but the new one will. * explicitly get definition of ARRAY_SIZE * Convert to ARRAY_SIZE when const is involved The following spatch finds additional instances where the array is const and the division is by the size of the type, not the size of the first element: ``` @ rule5a using "empty.iso" @ type T; const T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) @ rule6a using "empty.iso" @ type T; const T[] E; @@ - sizeof(E)/sizeof(T) + ARRAY_SIZE(E) ``` * New instances of ARRAY_SIZE added since initial spatch run * Use `ARRAY_SIZE` in docs (found by grep) * Manually use ARRAY_SIZE hs_set is expected to be the same size as uint16_t, though it's made of two 8-bit integers * Just like char, sizeof(uint8_t) is guaranteed to be 1 This is at least true on any plausible system where qmk is actually used. Per my understanding it's universally true, assuming that uint8_t exists: https://stackoverflow.com/questions/48655310/can-i-assume-that-sizeofuint8-t-1 * Run qmk-format on core C files touched in this branch Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
* | Merge remote-tracking branch 'origin/master' into developQMK Bot2022-08-291-1/+3
|\|
| * Redefinition of MIN is avoided in midi.c (#18203)3araht2022-08-291-1/+3
| |
* | Switch over MANUFACTURER and PRODUCT to string literals (#18183)Ryan2022-08-283-14/+12
|/
* Remove tmk_core 'serial' code (#17866)Joel Challis2022-08-083-413/+0
|
* [Core] `STM32_USB_USE_OTG1` => `USB_ENDPOINTS_ARE_REORDERABLE` (#17647)Nick Brassel2022-08-042-22/+23
|
* [Core] Add Raspberry Pi RP2040 support (#14877)Stefan Kerkmann2022-06-301-52/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Disable RESET keycode because of naming conflicts * Add Pico SDK as submodule * Add RP2040 build support to QMK * Adjust USB endpoint structs for RP2040 * Add RP2040 bootloader and double-tap reset routine * Add generic and pro micro RP2040 boards * Add RP2040 onekey keyboard * Add WS2812 PIO DMA enabled driver and documentation Supports regular and open-drain output configuration. RP2040 GPIOs are sadly not 5V tolerant, so this is a bit use-less or needs extra hardware or you take the risk to fry your hardware. * Adjust SIO Driver for RP2040 * Adjust I2C Driver for RP2040 * Adjust SPI Driver for RP2040 * Add PIO serial driver and documentation * Add general RP2040 documentation * Apply suggestions from code review Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Nick Brassel <nick@tzarc.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 11:33:42 +0000