| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Fix how USB queue overflow is handled in chibios.
This commit reverts PR 12472 (commit c823fe2d3f23ed090e36ce39beed4c448298bd2f),
and it implements the original intent of the commit in a better way.
The original intent of the above mentioned commit was to not deadlock the
keyboard when console is enabled, and hid_listen is not started.
The above mentioned commit had a few drawbacks:
1) When a lot of data was printed to the console, the queue would get full,
and drop data, even if hid_listen was running. (For example having matrix debug
enabled just didn't work right at all)
2) I believe the function in which this was implemented is used by all other
USB endpoints, so with the above change, overflow, and data loss could
happen in other important functions of QMK as well.
This commit implements deadlock prevention in a slightly similar way to how
it's done on AVR. There is an additional static local variable, that memorizes
whether the console has timeouted before. If we are in the timeouted=false
state, then we send the character normally with a 5ms timeout. If it does
time out, then hid_listen is likely not running, and future characters should
not be sent with a timeout, but those characters should still be sent if there
is space in the queue. The difference between the AVR implementation and this
one is that the AVR implementation checks the queue state directly, but this
implementation instead attempts to write the character with a zero timeout.
If it fails, then we remain in the timeouted=true state, if it succeeds, then
hid_listen started removing data from the queue, so we can go out of the
timeouted=true state.
* Added comment explaining the timeouted logic to console flow control.
* Console flow control: refactor chibios flowcontrol code to make it more readable, and rename the timeouted variable to timed_out on both chibios and lufa. Changed comments to says timed_out is an approximation of listener_disconnected, to make it clear that it's not the same thing
* fix typo
|
| |\| |
|
| | | |
|
| | |
| |
| | |
Co-authored-by: Ryan <fauxpark@gmail.com>
|
| | | |
|
| |\| |
|
| | |
| |
| | |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this commit, attaching an ARM-based (i.e. ChibiOS-based) keyboard that
uses CONSOLE_ENABLE = yes and produces debug messages would deadlock the
keyboard unless one was running hid_listen.
With this commit, dead-locking writes to the queue are detected and prevented.
fixes #5631
|
| | |
| |
| |
| |
| | |
* First stab at enabling builds of UF2-format binaries.
* Add description on producing a UF2 file.
|
| |\| |
|
| | | |
|
| | |
| |
| | |
This is in preparation for https://github.com/qmk/qmk_firmware/pull/10171
|
| | | |
|
| |\| |
|
| | |
| |
| | |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
| |\| |
|
| | |
| |
| |
| |
| | |
TAPPING_TERM_PER_KEY are defined (#12125)
Co-authored-by: checyr <32964049+checyr@users.noreply.github.com>
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
* Fix USER_PRINT on avr/atsam
* Update tmk_core/common/arm_atsam/_print.h
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
| |\| |
|
| | | |
|
| |\| |
|
| | |
| |
| | |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
| |\| |
|
| | | |
|
| | |
| |
| | |
This is in preparation for https://github.com/qmk/qmk_firmware/pull/10171
|
| |\| |
|
| | |
| |
| | |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
(#12130)
* Fix keycode mappings for via and ensure they don't change within protocol
* Update keycodes
* Fix broken keyboards
* added the missing keycodes found in via
* Remove invalid keycodes
Co-authored-by: David Hoelscher <infinityis@users.noreply.github.com>
|
| | | |
|
| | | |
|
| |\| |
|
| | | |
|
| | |
| |
| |
| |
| | |
* Split RGB Matrix
* Suspend State sync for rgb matrix
|
| |\| |
|
| | | |
|
| | |
| |
| |
| | |
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Migrate make_dfu_header to CLI
* lint fixes
* Update lib/python/qmk/cli/generate/dfu_header.py
Co-authored-by: Ryan <fauxpark@gmail.com>
* Rename object
Co-authored-by: Ryan <fauxpark@gmail.com>
|
| |\| |
|
| | |
| |
| |
| |
| |
| |
| | |
* Modified tmk_core/rules.mk to avoid linking errors
Added -fcommon flag to avoid linking errors due to multiple variable definitions. Though this is neither a definitive nor good solution, proper changes and use of extern keyword to avoid those multiple definitions must be made
* Comment updated
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Initial refactor of usb code within split_common
* Add headers
* Correct disable condition
* Format
* Align func name
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Initial refactor of ARM SLEEP_LED to enable more platforms
* fix build issues
* Disable SLEEP_LED for boards with no caps lock code
* Enable GPT14 for boards with caps lock code and SLEEP_LED enabled
* Enable GPT for boards with caps lock code and SLEEP_LED enabled
|
| |/
|
|
|
| |
* Relocate bootmagic logic to have single entrypoint
* Align init of layer state
|
| | |
|
| |
|
| |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
| | |
|
| |
|
| |
Co-authored-by: QMK Bot <hello@qmk.fm>
|
