diff options
author | Less/Rikki <86894501+lesshonor@users.noreply.github.com> | 2023-08-22 13:39:33 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-08-22 18:39:33 +0100 |
commit | 0d535381deeceb8e691e53ab98445efe884dc8f4 (patch) | |
tree | e93314193fd9d0d4ff54fee7eabd4350cd395ac5 /quantum/rgb_matrix/animations | |
parent | 1236c29b124f6582f46b3321fe81e8247d2caf5d (diff) |
fix: restore indicators to jellybean_raindrops (#21792)
After #21169, rgb_matrix_indicators() was limited to running on the
final render iteration. Since the jellybean_raindrops animation
immediately returns false after updating a single LED, the iteration
count no longer ends up high enough to render non-advanced indicators.
This change also brings jellybean_raindrops more in line with raindrops.
Diffstat (limited to 'quantum/rgb_matrix/animations')
-rw-r--r-- | quantum/rgb_matrix/animations/jellybean_raindrops_anim.h | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/quantum/rgb_matrix/animations/jellybean_raindrops_anim.h b/quantum/rgb_matrix/animations/jellybean_raindrops_anim.h index 6bde60053b..5d3df1059e 100644 --- a/quantum/rgb_matrix/animations/jellybean_raindrops_anim.h +++ b/quantum/rgb_matrix/animations/jellybean_raindrops_anim.h @@ -10,17 +10,16 @@ static void jellybean_raindrops_set_color(int i, effect_params_t* params) { } bool JELLYBEAN_RAINDROPS(effect_params_t* params) { + RGB_MATRIX_USE_LIMITS(led_min, led_max); if (!params->init) { // Change one LED every tick, make sure speed is not 0 if (scale16by8(g_rgb_timer, qadd8(rgb_matrix_config.speed, 16)) % 5 == 0) { jellybean_raindrops_set_color(random8_max(RGB_MATRIX_LED_COUNT), params); } - return false; - } - - RGB_MATRIX_USE_LIMITS(led_min, led_max); - for (int i = led_min; i < led_max; i++) { - jellybean_raindrops_set_color(i, params); + } else { + for (int i = led_min; i < led_max; i++) { + jellybean_raindrops_set_color(i, params); + } } return rgb_matrix_check_finished_leds(led_max); } |