summaryrefslogtreecommitdiffstats
path: root/keyboards/kakunpc
diff options
context:
space:
mode:
authorSergey Vlasov <sigprof@gmail.com>2023-08-23 12:13:03 +0300
committerGitHub <noreply@github.com>2023-08-23 10:13:03 +0100
commitb1fbfaaacc61af1efe1b897aeed0dc7389d91708 (patch)
tree7d0ebe6e8730ec9fe7253743ccddbcca8fc82133 /keyboards/kakunpc
parentc2b837514bd23444dcd08cb5b60d2aa78944b88a (diff)
keychron/c2_pro/ansi/white: Fix column 19 in the custom matrix (#21805)
Although `keychron/c2_pro/ansi/rgb` and `keychron/c2_pro/ansi/white` use the same custom matrix code, the matrix layouts are slightly different; in particular, only the `keychron/c2_pro/ansi/white` board actually uses column 19. However, the handling of column 19 in the custom matrix code was broken, therefore that column did not work. Looks like the custom matrix code assumes that `SHIFT_COL_END` refers to the last column connected to the shift register, and not to the column past that; so the value of `SHIFT_COL_END` needs to be changed from 19 to 18 (columns 11...18 are connected to the shift register, and column 19 is connected to the C14 pin). Also the code which was determining `SIZE_T` and `UNSELECT_ALL_COL` had an off-by-one bug when counting the required number of bits (again due to the confusion on the `SHIFT_COL_END` meaning); this had been fixed too (the actual behavior of that part of the code did not change, because both the old and the new version select the 8 bit variant).
Diffstat (limited to 'keyboards/kakunpc')
0 files changed, 0 insertions, 0 deletions