summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDimitris Papavasiliou <dpapavas@protonmail.ch>2020-12-06 03:50:02 +0200
committerGitHub <noreply@github.com>2020-12-06 12:50:02 +1100
commit5cf70f3993ceecf24dc46c6791552f268d82ae91 (patch)
tree2a8049ada0859d82f67edf97f4f6880be833060a /drivers
parent54b932e84404725d3ac77d36faa2001c0aa8267b (diff)
Fix error handling in SPI master. (#11122)
Co-authored-by: Dimitris Papavasiliou <dpapavas@gmail.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/avr/spi_master.c16
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/avr/spi_master.c b/drivers/avr/spi_master.c
index f91baf70ba..cbec9f36e1 100644
--- a/drivers/avr/spi_master.c
+++ b/drivers/avr/spi_master.c
@@ -140,27 +140,33 @@ spi_status_t spi_read() {
}
spi_status_t spi_transmit(const uint8_t *data, uint16_t length) {
- spi_status_t status = SPI_STATUS_ERROR;
+ spi_status_t status;
for (uint16_t i = 0; i < length; i++) {
status = spi_write(data[i]);
+
+ if (status < 0) {
+ return status;
+ }
}
- return status;
+ return SPI_STATUS_SUCCESS;
}
spi_status_t spi_receive(uint8_t *data, uint16_t length) {
- spi_status_t status = SPI_STATUS_ERROR;
+ spi_status_t status;
for (uint16_t i = 0; i < length; i++) {
status = spi_read();
- if (status > 0) {
+ if (status >= 0) {
data[i] = status;
+ } else {
+ return status;
}
}
- return (status < 0) ? status : SPI_STATUS_SUCCESS;
+ return SPI_STATUS_SUCCESS;
}
void spi_stop(void) {