diff options
| author | Stefan Kerkmann <karlk90@pm.me> | 2022-07-17 21:08:55 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-17 21:08:55 +0200 |
| commit | a304a9b51ed6e876f25c579f383e2cbf9afb8353 (patch) | |
| tree | f8826b4d9014b0869517214f7afbc4cfa9892272 /drivers/sensors | |
| parent | 4779539543759580b652b719e96566e16cf7132b (diff) | |
Use correct angle tune range of +/-127 on PMW33XX (#17708)
...partially reverts 580bcff4f65a3a9ee301de0fd036de7b610c7ee2 as the
datasheet doesn't claim that the angle tuning as limited to +/- 30
degrees.
Diffstat (limited to 'drivers/sensors')
| -rw-r--r-- | drivers/sensors/pmw33xx_common.c | 2 | ||||
| -rw-r--r-- | drivers/sensors/pmw33xx_common.h | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/sensors/pmw33xx_common.c b/drivers/sensors/pmw33xx_common.c index 0a8989fcea..13164cb150 100644 --- a/drivers/sensors/pmw33xx_common.c +++ b/drivers/sensors/pmw33xx_common.c @@ -166,7 +166,7 @@ bool pmw33xx_init(uint8_t sensor) { wait_ms(1); pmw33xx_write(sensor, REG_Config2, 0x00); - pmw33xx_write(sensor, REG_Angle_Tune, CONSTRAIN(ROTATIONAL_TRANSFORM_ANGLE, -30, 30)); + pmw33xx_write(sensor, REG_Angle_Tune, CONSTRAIN(ROTATIONAL_TRANSFORM_ANGLE, -127, 127)); pmw33xx_write(sensor, REG_Lift_Config, PMW33XX_LIFTOFF_DISTANCE); if (!pmw33xx_check_signature(sensor)) { diff --git a/drivers/sensors/pmw33xx_common.h b/drivers/sensors/pmw33xx_common.h index eab8518baa..87e8b34d5c 100644 --- a/drivers/sensors/pmw33xx_common.h +++ b/drivers/sensors/pmw33xx_common.h @@ -59,8 +59,8 @@ _Static_assert(sizeof((pmw33xx_report_t){0}.motion) == 1, "pmw33xx_report_t.moti # define ROTATIONAL_TRANSFORM_ANGLE 0x00 #endif -#if ROTATIONAL_TRANSFORM_ANGLE > 30 || ROTATIONAL_TRANSFORM_ANGLE < (-30) -# error ROTATIONAL_TRANSFORM_ANGLE has to be in the range of +/- 30 for all PMW33XX sensors. +#if ROTATIONAL_TRANSFORM_ANGLE > 127 || ROTATIONAL_TRANSFORM_ANGLE < (-127) +# error ROTATIONAL_TRANSFORM_ANGLE has to be in the range of +/- 127 for all PMW33XX sensors. #endif // Support single and plural spellings |