diff options
| author | QMK Bot <hello@qmk.fm> | 2021-11-12 07:33:52 +0000 |
|---|---|---|
| committer | QMK Bot <hello@qmk.fm> | 2021-11-12 07:33:52 +0000 |
| commit | 058308cc74286b8bbe4bc8427d8cd27be1b39d3a (patch) | |
| tree | 2bdb2dbda69590650f436873116e367779cdd24c /docs | |
| parent | f3fa56c32a240012c7b8c13be10d0b787d849ff3 (diff) | |
| parent | 7c2b2c81b53d055c66a15bd9ced92f548ca28ad6 (diff) | |
Merge remote-tracking branch 'origin/master' into develop
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/pr_checklist.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 817ed22d41..94c62c6535 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -101,6 +101,9 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - submitters can have a personal (or bells-and-whistles) keymap showcasing capabilities in the same PR but it shouldn't be embedded in the 'default' keymap - submitters can also have a "manufacturer-matching" keymap that mirrors existing functionality of the commercial product, if porting an existing board - Do not include VIA json files in the PR. These do not belong in the QMK repository as they are not used by QMK firmware -- they belong in the [VIA Keyboard Repo](https://github.com/the-via/keyboards) +- Do not include source files from another keyboard or vendors keyboard folder. Including core files is fine. + - For instance, only `wilba_tech` boards using be including `keyboards/wilba_tech/wt_main.c` and `keyboards/wilba_tech/wt_rgb_backlight.c`. But including `drivers/sensors/pmw3360.c` is absolutely fine. + - Code that needs to be used by multiple boards is a candidate for core code changes, and should be separated out. Also, specific to ChibiOS: - **strong** preference to using existing ChibiOS board definitions. |