summaryrefslogtreecommitdiffstats
path: root/data/constants
diff options
context:
space:
mode:
authorStefan Kerkmann <karlk90@pm.me>2023-07-28 02:05:01 +0200
committerGitHub <noreply@github.com>2023-07-28 01:05:01 +0100
commit32174abcfae373eac2659dd9de255b3c1792d238 (patch)
tree9b95b6516a260642de21e8e880ad0d0502c71a02 /data/constants
parent3a413e4bad2cad306eba7ecc1604e4a147c905b5 (diff)
Update keyboard report descriptor for USB compliance (#21626)
Running the "HID Tests" suite of the USB 3 Command Verifier (USB3CV) tool resulted in the following error: (HID: 3.2.61) The report descriptor returned in response to a GetDescriptor(Report) must be compliant with the HID specification. Byte Number: 37h ( 55d) Data Field: 91 02 Mnemonic: Output Value: (Variable) Errors: Error: LOGICAL MAX MUST be bounded by Report Size The error stems from the fact that logical minimum and maximum are global items, which means that the next item in a report descriptor inherits the value from the previously set value. In this case the status leds item inherited the logical minimum (=0) and maximum (=255) from the keycodes item. As the status leds set a report size of 1 bit, wich can only hold a boolean, it becomes clear that this range would never fit. The fix is straightforward, we just define a appropriate logical maximum (=1), the mismatch is solved and our keyboard now passes the compliance tests. Defining the logical minimum is redundant in this case but is kept to form a logical block.
Diffstat (limited to 'data/constants')
0 files changed, 0 insertions, 0 deletions