summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabián González Martín <61802930+FabSchwul@users.noreply.github.com>2021-02-28 17:01:16 +0100
committerGitHub <noreply@github.com>2021-02-28 08:01:16 -0800
commit90c7ae70c68662c671ee1026d1c5abe67026c473 (patch)
tree5379b2915d3899e718e42cd0987c4c0f7e16f177
parentef49a9243b15cade7bec006f90cd0457c247e000 (diff)
Modified tmk_core/rules.mk to avoid linking errors (#10728)
* Modified tmk_core/rules.mk to avoid linking errors Added -fcommon flag to avoid linking errors due to multiple variable definitions. Though this is neither a definitive nor good solution, proper changes and use of extern keyword to avoid those multiple definitions must be made * Comment updated
-rw-r--r--tmk_core/rules.mk5
1 files changed, 5 insertions, 0 deletions
diff --git a/tmk_core/rules.mk b/tmk_core/rules.mk
index f5f758943e..bbcfc1e4d1 100644
--- a/tmk_core/rules.mk
+++ b/tmk_core/rules.mk
@@ -108,6 +108,10 @@ endif
CFLAGS += -Wa,-adhlns=$(@:%.o=%.lst)
CFLAGS += $(CSTANDARD)
+# This fixes lots of keyboards linking errors but SHOULDN'T BE A FINAL SOLUTION
+# Fixing of multiple variable definitions must be made.
+CFLAGS += -fcommon
+
#---------------- Compiler Options C++ ----------------
# -g*: generate debugging information
# -O*: optimization level
@@ -124,6 +128,7 @@ CXXFLAGS += -O$(OPT)
CXXFLAGS += -w
CXXFLAGS += -Wall
CXXFLAGS += -Wundef
+
ifneq ($(strip $(ALLOW_WARNINGS)), yes)
CXXFLAGS += -Werror
endif