summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakeshi Nishio <kkeennnn+github@gmail.com>2021-01-20 11:08:06 +0900
committerGitHub <noreply@github.com>2021-01-19 18:08:06 -0800
commit71f067a60ef01df6a58c086a939a58e40ab7e972 (patch)
tree1121e05ae3301df687a0436e120af1654e4bb7ed
parent974d3f1ffdbc4478f8d430021e74cf76e122661f (diff)
Fix wrong key when "Music Map" is used with MAJOR_MODE. (#11234)
With MAJOR_MODE (= major scale), keys in one octave is not 12 but 7. To solve this problem, change divisor number from 12 to 7 at %(Modulo) and /(Division). NOTE: The last 12 represents half step keys in one octave for pitch calculation.
-rw-r--r--quantum/process_keycode/process_music.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/quantum/process_keycode/process_music.c b/quantum/process_keycode/process_music.c
index b61a16e878..eb06be96c2 100644
--- a/quantum/process_keycode/process_music.c
+++ b/quantum/process_keycode/process_music.c
@@ -191,7 +191,7 @@ bool process_music(uint16_t keycode, keyrecord_t *record) {
note = music_starting_note + music_offset + 36 + music_map[record->event.key.row][record->event.key.col];
} else {
uint8_t position = music_map[record->event.key.row][record->event.key.col];
- note = music_starting_note + music_offset + 36 + SCALE[position % 12] + (position / 12) * 12;
+ note = music_starting_note + music_offset + 36 + SCALE[position % 7] + (position / 7) * 12;
}
# else
if (music_mode == MUSIC_MODE_CHROMATIC)