populate flake-input: remove uploads left behind

Uploads an interrupted run left behind in .populate/flake-uploads only got
removed before the same source uploaded again.  Delivering a flake or
flake input removes its upload directory now, and the empty
.populate/flake-inputs once the last roots are gone.

An edge case leaves an upload behind between two deploys.

1 files changed, 17 insertions, 0 deletions

diff --git a/tests/scenarios.nix b/tests/scenarios.nix
index 6dbb84d..eb6bbec 100644
--- a/tests/scenarios.nix
+++ b/tests/scenarios.nix
@@ -956,6 +956,23 @@ assert !(krops.isLocalTarget (targets.remote "/"));
         '';
       };
     })
+    # An upload an interrupted run left behind.
+    (s "upload-leftover" {
+      phases = [
+        {
+          sources.x.flake = { flake = "/fixtures/top"; fetchOnTarget = true; };
+          check = checkFlake { attr = "msg"; expected = "top:dep+inner,sub"; };
+          mutate = ''
+            mkdir -p "$T"/.populate/flake-uploads/x/tree
+            echo half > "$T"/.populate/flake-uploads/x/tree/half
+          '';
+        }
+        {
+          sources.x.flake = { flake = "/fixtures/top"; fetchOnTarget = true; };
+          check = checkFlake { attr = "msg"; expected = "top:dep+inner,sub"; };
+        }
+      ];
+    })
   ] ++ lib.optional (targetKind == "local")
     # The target has the path the input is locked to.
     (s "uselocal" {