aboutsummaryrefslogtreecommitdiffstats
path: root/src/federation/party.rs
diff options
context:
space:
mode:
Diffstat (limited to 'src/federation/party.rs')
-rw-r--r--src/federation/party.rs42
1 files changed, 34 insertions, 8 deletions
diff --git a/src/federation/party.rs b/src/federation/party.rs
index a12dc7f..2c8dc4b 100644
--- a/src/federation/party.rs
+++ b/src/federation/party.rs
@@ -314,7 +314,15 @@ pub(crate) async fn main() -> Result<()> {
moves to it, once every party's nodes run a continuum that knows it",
current.revision
);
+ warn_unready(&node.counts().await?, later);
}
+ } else if let Some(revision) = next["revision"]
+ .as_str()
+ .and_then(Id::from_hex)
+ .and_then(|id| Revision::of(&id))
+ && revision != current.revision
+ {
+ warn_unready(&node.counts().await?, revision);
}
println!("{}", serde_json::to_string_pretty(&next)?);
return Ok(());
@@ -755,18 +763,21 @@ async fn vote(
})) if hash == proposal => version,
_ => bail!("the node's {proposing} isn't the proposal it names"),
};
- // A later revision: the node knows it, or it stops at the version once it passes.
+ // A later revision: the node knows it, or it stops at the version once it passes; and
+ // so does every other node not known to know it.
if yes
&& let Ok(version) = Version::read(&proposed)
&& version.revision != current.revision
- && !node.revisions().await?.contains(&version.revision.id())
{
- bail!(
- "{proposal} moves to {}, which the node doesn't know: once it passed, a node that \
- doesn't stops at it, and votes nothing till upgraded; upgrade this node and every \
- other of the party to a continuum that knows it, then back it",
- version.revision
- );
+ if !node.revisions().await?.contains(&version.revision.id()) {
+ bail!(
+ "{proposal} moves to {}, which the node doesn't know: once it passed, a node \
+ that doesn't stops at it, and votes nothing till upgraded; upgrade this node \
+ and every other of the party to a continuum that knows it, then back it",
+ version.revision
+ );
+ }
+ warn_unready(&counts, version.revision);
}
// The votes on its party's earlier proposals it backed, for the nays among them.
let mut nays = Vec::new();
@@ -816,6 +827,21 @@ async fn vote(
node.put(&cast).await
}
+/// Warns of the nodes not known to know `revision`, by `counts` (`client::unready`).
+fn warn_unready(counts: &JsonValue, revision: Revision) {
+ let behind = client::unready(counts, revision);
+ if behind.is_empty() {
+ return;
+ }
+ eprintln!(
+ "Warning: these nodes aren't known to know {revision}, as far as the node heard from \
+ them; once a version of it passes, each stops at it till upgraded:"
+ );
+ for line in behind {
+ eprintln!(" {line}");
+ }
+}
+
/// Signs again what a move refused: of the latest event it signed at each place, its key
/// set and its node list, those the node refuses as not above its checkpoint's heads, or
/// as built on one it refuses.