From 7e0686c6b4b456ec4e6e15689694b1bcf96c301f Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 10 Sep 2018 20:58:52 +0200 Subject: logging vty: deprecate the 'everything' keyword The 'logging level all everything' has not had an effect for some time now. The plan is to bring back its old functionality, but to keep it deprecated and rather define a less confusing name. * Deprecate 'everything'. * Do not write 'everything' during 'write file' or 'show running-config', which we curiously still do until now. BTW, the reason why we need to compose a complete list of categories for the deprecated 'everything' command is explained in detail in the commit log for I3b083f27e3d751ccec258880ae7676e9af959a63 Change-Id: Ib75fedb0572570a61bb34ee729a2af86cf5f16da --- tests/logging/logging_vty_test.vty | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) (limited to 'tests') diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index c57b70f8..a2c1e74b 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -1,11 +1,9 @@ logging_vty_test> enable -logging_vty_test# ! Note that 'logging level all everything' is still printed! logging_vty_test# show running-config ... log stderr -... - logging level all everything +... !logging level all logging level aa debug logging level bb info logging level ccc notice @@ -39,7 +37,7 @@ logging_vty_test# list logging print level (0|1) logging print file (0|1|basename) [last] logging set-log-mask MASK - logging level (all|aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf) (everything|debug|info|notice|error|fatal) + logging level (all|aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf) (debug|info|notice|error|fatal) show logging vty ... !logging @@ -64,20 +62,18 @@ logging_vty_test# logging level ? ... logging_vty_test# logging level aa ? - everything Don't use. It doesn't log anything - debug Log debug messages and higher levels - info Log informational messages and higher levels - notice Log noticeable messages and higher levels - error Log error messages and higher levels - fatal Log only fatal messages + debug Log debug messages and higher levels + info Log informational messages and higher levels + notice Log noticeable messages and higher levels + error Log error messages and higher levels + fatal Log only fatal messages logging_vty_test# logging level all ? - everything Don't use. It doesn't log anything - debug Log debug messages and higher levels - info Log informational messages and higher levels - notice Log noticeable messages and higher levels - error Log error messages and higher levels - fatal Log only fatal messages + debug Log debug messages and higher levels + info Log informational messages and higher levels + notice Log noticeable messages and higher levels + error Log error messages and higher levels + fatal Log only fatal messages logging_vty_test# log-sweep @@ -181,7 +177,7 @@ DEEE FATAL Log message for DEEE on level LOGL_FATAL logging_vty_test# ! Old 'logging level all everything' has no effect logging_vty_test# logging level all everything -% Ignoring deprecated logging level everything +% Ignoring deprecated logging level 'everything' keyword logging_vty_test# log-sweep eee DEEE NOTICE Log message for DEEE on level LOGL_NOTICE DEEE ERROR Log message for DEEE on level LOGL_ERROR -- cgit v1.2.3