From 8c58af139dccb418cc48e5bed5a370ed4dea2a85 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 20 Mar 2019 11:26:58 +0100 Subject: signal.c: Fix osmo_signal_talloc_ctx_init() This function is broken ever since it was added back in 2018 in commit Id58ca18eb826b8f4183a7cf0dbb2b38cba702a09 Rather than allocating from the user-supplied 'root_ctx', it is allocating from the context that it's trying to create (which is NULL at that time, rendering the entire operation more or less a no-op. For sure you will not see osmo_signal structures never in any talloc report. Change-Id: I922d26815a3baa5be74bd3ee89d498555882d62f --- src/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/signal.c b/src/signal.c index 7e53e83d..be3b7778 100644 --- a/src/signal.c +++ b/src/signal.c @@ -52,7 +52,7 @@ struct signal_handler { * \returns the new osmo_signal talloc context, e.g. for reporting */ void *osmo_signal_talloc_ctx_init(void *root_ctx) { - tall_sigh_ctx = talloc_named_const(tall_sigh_ctx, 0, "osmo_signal"); + tall_sigh_ctx = talloc_named_const(root_ctx, 0, "osmo_signal"); return tall_sigh_ctx; } -- cgit v1.2.3