From 888dc7d31aa4b39ba8e08884c39be1c09c92f82a Mon Sep 17 00:00:00 2001 From: Stefan Sperling Date: Mon, 26 Feb 2018 19:17:02 +0100 Subject: print BIG FAT ERROR message if osmo_fsm lacks event names Event names are displayed in VTY commands so all FSM should have them. Print an error message if an FSM is registered without event names. We could also return an error code, however at present no caller checks the return value of osmo_fsm_register() so this would be pointless. Add event names to the test FSM and update expected output accordingly. Change-Id: I08b100d62b5c50bf025ef87d31ea39072539cf37 Related: OS#3008 --- src/fsm.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/fsm.c b/src/fsm.c index 176aa8ab..342542fb 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -154,6 +154,8 @@ int osmo_fsm_register(struct osmo_fsm *fsm) } if (osmo_fsm_find_by_name(fsm->name)) return -EEXIST; + if (fsm->event_names == NULL) + LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has no event names! Please fix!\n", fsm->name); llist_add_tail(&fsm->list, &osmo_g_fsms); INIT_LLIST_HEAD(&fsm->instances); -- cgit v1.2.3