From 4e0add239f6516c11631a7539653bac6b6a51970 Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <neels@hofmeyr.de>
Date: Mon, 9 Jul 2018 19:24:16 +0200
Subject: vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy()

Change-Id: Ibf870ae02be706f802482f7cff6589a70cde8320
---
 src/vty/command.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

(limited to 'src/vty')

diff --git a/src/vty/command.c b/src/vty/command.c
index 689609c0..51dece3a 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -1311,18 +1311,11 @@ cmd_deopt(const char *str)
 	 * match check for "blah"
 	 */
 	size_t len = strlen(str);
-	char *tmp;
 
 	if (len < 3)
 		return NULL;
 
-	/* tmp will hold a string of len-2 chars, so 'len' size is fine */
-	tmp = talloc_size(tall_vty_cmd_ctx, len);
-
-	memcpy(tmp, (str + 1), len - 2);
-	tmp[len - 2] = '\0';
-
-	return tmp;
+	return talloc_strndup(tall_vty_cmd_ctx, str + 1, len - 2);
 }
 
 static enum match_type
-- 
cgit v1.2.3