From ebd3cddb4c75b284b0d3345ab81980f8f4b44b62 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Sat, 18 Nov 2017 23:07:38 +0100 Subject: osmo_strlcpy: sanitize: don't memcpy from NULL src even if len is 0 Some callers pass NULL and len == 0. The semantics are that we then nul-terminate an emtpy string. Avoid a sanitizer warning by not calling memcpy() for the NULL case. Change-Id: I883048cf2807e606c6481634dbd569fc12aed889 --- src/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/utils.c') diff --git a/src/utils.c b/src/utils.c index f63ff891..bc5329d8 100644 --- a/src/utils.c +++ b/src/utils.c @@ -385,7 +385,8 @@ size_t osmo_strlcpy(char *dst, const char *src, size_t siz) if (siz) { size_t len = (ret >= siz) ? siz - 1 : ret; - memcpy(dst, src, len); + if (src) + memcpy(dst, src, len); dst[len] = '\0'; } return ret; -- cgit v1.2.3