From 399a6f09ff051988e2e840185ad1f7f5b8a2adce Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Sun, 18 Jun 2017 14:07:37 +0200 Subject: Fix warnings: tolower() and similar require uchar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit utils.c: In function 'osmo_str2lower': utils.c:277:3: warning: array subscript has type 'char' [-Wchar-subscripts] out[i] = tolower(in[i]); And according to man: If c is neither an unsigned char value nor EOF, the behavior of these func‐ tions is undefined. Change-Id: I3fed2ab6a4efba9f8a21fcf84a5b3a91e8df084f --- src/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/utils.c') diff --git a/src/utils.c b/src/utils.c index a1881f06..1c176f86 100644 --- a/src/utils.c +++ b/src/utils.c @@ -274,7 +274,7 @@ void osmo_str2lower(char *out, const char *in) unsigned int i; for (i = 0; i < strlen(in); i++) - out[i] = tolower(in[i]); + out[i] = tolower((const unsigned char)in[i]); out[strlen(in)] = '\0'; } @@ -287,7 +287,7 @@ void osmo_str2upper(char *out, const char *in) unsigned int i; for (i = 0; i < strlen(in); i++) - out[i] = toupper(in[i]); + out[i] = toupper((const unsigned char)in[i]); out[strlen(in)] = '\0'; } #endif /* HAVE_CTYPE_H */ -- cgit v1.2.3