From 171ef826e1489031bc48745f29fa2d4657bf165f Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 28 Mar 2019 10:49:05 +0100 Subject: make all library-internal static buffers thread-local We have a number of library-internal static global buffers which are mainly used for various stringification functions. This worked as all of the related Osmocom programs were strictly single-threaded. Let's make those buffers at least thread-local. This way every thread gets their own set of buffers, and it's safe for multiple threads to execute the same functions once. They're of course still not re-entrant. If you need re-entrancy, you will need to use the _c() or _buf() suffix version of those functions and work with your own (stack or heap) buffers. Change-Id: I50eb2436a7c1261d79a9d2955584dce92780ca07 --- src/msgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/msgb.c') diff --git a/src/msgb.c b/src/msgb.c index 940135f6..4edbdf34 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -511,7 +511,7 @@ char *msgb_hexdump_buf(char *buf, size_t buf_len, const struct msgb *msg) */ const char *msgb_hexdump(const struct msgb *msg) { - static char buf[4100]; + static __thread char buf[4100]; return msgb_hexdump_buf(buf, sizeof(buf), msg); } -- cgit v1.2.3