From 2bcc873e93be0554694ade1f2ee6ef0ac8011d05 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 9 Apr 2018 01:35:02 +0200 Subject: osmo_fsm_inst_find_by_name(): guard against strcmp(NULL) strcmp() *must not* be passed NULL pointers, or we hit: ../../../src/libosmocore/src/fsm.c:123:8: runtime error: null pointer passed as argument 2, which is declared to never be null ASAN:DEADLYSIGNAL (Or, alternatively, a segfault.) If any of the search string or an FSM instance's name string should be NULL, simply never match. Technically, an FSM should never have a NULL name, but a current bug actually allows this (pass NULL id to alloc), which will be addressed by an upcoming patch. To test for it, we need to first make sure this here doesn't segfault. Change-Id: I2e5f82c06d1a4727bd93e955366e3b62b2df1b32 --- src/fsm.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/fsm.c') diff --git a/src/fsm.c b/src/fsm.c index c5256da5..88de0116 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -119,7 +119,12 @@ struct osmo_fsm_inst *osmo_fsm_inst_find_by_name(const struct osmo_fsm *fsm, { struct osmo_fsm_inst *fi; + if (!name) + return NULL; + llist_for_each_entry(fi, &fsm->instances, list) { + if (!fi->name) + continue; if (!strcmp(name, fi->name)) return fi; } -- cgit v1.2.3