From 7e27b14ef29da0d8f834d8aba03551c34341ba90 Mon Sep 17 00:00:00 2001 From: Philipp Maier Date: Thu, 22 Mar 2018 17:26:46 +0100 Subject: gsm_08_08: correct speech codec defaults The speech codec defaults are not correct. The defaults recommended in 3GPP TS 28.062, Table 7.11.3.1.3-2 are limited by 3GPP TS 48.008, Section 3.2.2.103. Some defaults are actually reserved for future use. Also the endianess of the 16 bit values is reversed. - correct values so that they match the specification - transmit bytes in the correct endianess Change-Id: I6c3a34d39a375d71c4128fd38f06629e8b98b100 --- include/osmocom/gsm/protocol/gsm_08_08.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'include') diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h index 947f90f2..4539b960 100644 --- a/include/osmocom/gsm/protocol/gsm_08_08.h +++ b/include/osmocom/gsm/protocol/gsm_08_08.h @@ -460,16 +460,16 @@ struct gsm0808_speech_codec { * configuration that is used on the air interface (Um). * * Default values for FR_AMR, HR_AMR and OHR_AMR: - * See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred - * Configurations for the Adaptive Multi-Rate Codec Types + * See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred Configurations for + * the Adaptive Multi-Rate Codec Types and 3GPP TS 48.008, Section 3.2.2.103. * * Default values for FR_AMR_WB, OFR_AMR_WB and OHR_AMR_WB: * See also: 3GPP TS 26.103, Table 5.7-1: Allowed Configurations * for the Adaptive Multi-Rate - Wideband Codec Types */ enum gsm0808_speech_codec_defaults { - GSM0808_SC_CFG_DEFAULT_FR_AMR = 0xffff, + GSM0808_SC_CFG_DEFAULT_FR_AMR = 0x57ff, GSM0808_SC_CFG_DEFAULT_HR_AMR = 0x073f, - GSM0808_SC_CFG_DEFAULT_OHR_AMR = 0xffff, + GSM0808_SC_CFG_DEFAULT_OHR_AMR = 0x57ff, GSM0808_SC_CFG_DEFAULT_FR_AMR_WB = 0x01, GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB = 0x3f, GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB = 0x01, -- cgit v1.2.3