summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* lapd: Check in rslms_rx_rll() if lapdm context was initialized earlierDaniel Willmann2012-12-261-2/+18
| | | | | | | | | | | | | | | | | | This was found while implementing handover on a sysmobts. When we receive a channel release request for a channel that was never really activated (set_lapdm_context() was not called) we segfault in lapd_recv_dlsap(). We now return early with -EINVAL in rslms_rx_rll() if we receive a message that assumes set_lapdm_context() was already called. These are: * RSL_MT_UNIT_DATA_REQ * RSL_MT_DATA_REQ * RSL_MT_SUSP_REQ * RSL_MT_REL_REQ A test case was added to trigger the issue.
* core: Fix missing include in msgfile.c for getlineSylvain Munaut2012-12-121-0/+1
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* build: Don't use the deprecated INCLUDES in the various Makefile.amSylvain Munaut2012-12-115-10/+5
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsm: Add method to find ARFCN based on frequencySylvain Munaut2012-12-112-45/+66
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* sms: Print 'network' or 'mobile' when creating the SMC/SMRHolger Hans Peter Freyther2012-12-062-3/+4
|
* gsm/a5: Return -ENOTSUP if the selected cipher is not supportedSylvain Munaut2012-12-061-2/+6
| | | | | | Extracted from a patch by Max Suraev Max.Suraev@fairwaves.ru> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* lapd: Use LOGL_ERROR for messgaes that are wrong in the given contextHolger Hans Peter Freyther2012-11-261-14/+14
| | | | Log message that are either too big or have the C/R bit set as error.
* misc: Use static const struct for LAPD and AbisHolger Hans Peter Freyther2012-11-222-2/+2
|
* sms: Mark the state dispatch table as static constHolger Hans Peter Freyther2012-11-222-4/+4
| | | | | | GCC 4.7.2 was already smart enough to see that the table is const so there is no change in the generated assembly code. For some reason the dispatch is still going through one relocation.
* sms: Fix typos in the comments and log messages.Holger Hans Peter Freyther2012-11-222-5/+5
|
* smr: Introduce an id and prefix all log messages with SMR(ID)Holger Hans Peter Freyther2012-11-221-31/+68
| | | | | | | | | | When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMR instance. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMR(ID). This change is ABI and API incompatible with previous versions of libosmogsm.
* smc: Introduce an id and prefix all log messages with SMC(ID)Holger Hans Peter Freyther2012-11-221-30/+60
| | | | | | | | | | | | | | When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMC. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMC(ID). This change is ABI and API incompatible with previous versions of libosmogsm. Example: SMC(100) instance created SMC(100) message MNSMS-EST-REQ received in state IDLE
* smc: Fix a typo in the smc codeHolger Hans Peter Freyther2012-11-141-1/+1
|
* smc: Print the current state of the SMSHolger Hans Peter Freyther2012-11-111-1/+3
| | | | | | When the connection may not released print the name of the current state to ease with debugging and verification that this is not a valid state transition.
* sms: Remove the commented out code that was the default in OpenBSCHolger Hans Peter Freyther2012-11-111-1/+0
| | | | | This code got copied from OpenBSC and we used the network specific and private numbering plan. Remove it as it can be easily set.
* sms: Reduce the logging level to debugHolger Hans Peter Freyther2012-11-111-3/+3
| | | | | <001c> gsm0411_smr.c:175 TX: MNSMS-REL-REQ adds little value so I am reducing it to a debug statement.
* GSM48: Avoid unaligned access in gsm48_construct_raAndreas Eversberg2012-11-051-1/+3
| | | | | This avoids an unaligned access on platforms that don't support them, such as ARMv4/ARMv5.
* Do not use --version-script linker flag on OSXTobias Engel2012-10-272-2/+2
| | | | | Add a check to not use --version-script linker flag if compiled on OSX since it doesn't exist there
* Define struct iphdr for OSXTobias Engel2012-10-271-1/+1
| | | | | | | | | | Use FreeBSD struct iphdr definition for OSX also. From the commentary in the source file: On BSD the IPv4 struct is called struct ip and instead of iXX the members are called ip_XX. One could change this code to use struct ip but that would require to define _BSD_SOURCE and that might have other complications. Instead make sure struct iphdr is present on FreeBSD.
* logging: Make sure to install standard "end" command in VTY nodeHarald Welte2012-10-221-0/+2
| | | | | When you are in the config-log VTY node, you expect "end" to work like in any other sub-node of config.
* logging: Don't forget to save "logging filter all 1"Harald Welte2012-10-221-0/+4
| | | | | | | Prior to this fix, a persistent file or syslog log configuration didn't work across an application re-start, as the "logging filter all 1" was never saved and thus no messages were logged.
* Doc: Adding new parameter descriptions in gprs_bssgp_bss.cAndreas Eversberg2012-09-301-1/+9
|
* Fix: Correcting bssgp_tx_fc_bvc, bssgp_tx_fc_ms, bssgp_tx_ul_udAndreas Eversberg2012-09-302-9/+28
|
* Fix: gprs_ns_destroy() now frees all NSVCs and its timersAndreas Eversberg2012-09-291-4/+14
| | | | | Freeing memory of registered timers and file descriptors cause corrupt lists.
* logging.c: Do not crash on empty category nameNico Golde2012-09-271-5/+7
| | | | | log_parse_category_mask(), skip log category name right away if name is NULL to prevent passing a NULL ptr to strlen.
* gsm_utils.c: in 7bit decoding, first check if the last character was an ↵Nico Golde2012-09-211-5/+5
| | | | extension character before doing anything else
* gsm_utils: Fix up coding style in previous patchHarald Welte2012-09-201-2/+2
| | | | 'if' is not a function, so we have space before parenthesis.
* gsm_utils.c: cleanup + do not use dynamic memory when decoding 7bit messagesNico Golde2012-09-201-14/+13
|
* logging: Introduce a print_filename flag for the logtargetHolger Hans Peter Freyther2012-09-111-5/+17
| | | | | | Introduce a print_filename attribute for each logtarget. Initialize it with 1 to be backward compatible with earlier versions. The bit is taken from an existint bitfield. There were at least six bits left of the byte.
* vty: Address compiler warning about the const qualifierHolger Hans Peter Freyther2012-09-111-1/+1
| | | | | vty.c: In function 'vty_out_newline': vty.c:294:12: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
* vty: Address compiler warning about tolowerHolger Hans Peter Freyther2012-09-111-0/+1
| | | | | | | Include ctype.h to have a declaration of tolower. utils.c: In function 'vty_cmd_string_from_valstr': utils.c:95:6: warning: implicit declaration of function 'tolower' [-Wimplicit-function-declaration]
* gsm: Address compiler warning about unused variable 'z'Holger Hans Peter Freyther2012-09-111-3/+4
| | | | | | | | The comment explains why we don't care about the content of z, stop storing it. gsm_utils.c: In function 'gsm_7bit_encode': gsm_utils.c:253:13: warning: variable 'z' set but not used [-Wunused-but-set-variable]
* logging: Mark the log_info_cat pointer as constsHolger Hans Peter Freyther2012-09-111-2/+3
| | | | | | Applications should keep the log area in a static const area. Mark the pointer as const to address compiler warnings in OpenBSC, cast the const away for the osmo_log_info as it is not declared as const.
* Gb: Add functions for sending flow control messages from BSS sideHarald Welte2012-09-101-0/+105
|
* Gb: Add header file for BSS-side BSSGP functionsHarald Welte2012-09-101-0/+1
| | | | .. not sure how we could have missed that so far.
* libosmogb: make build conditional, disable in embedded buildHarald Welte2012-09-081-0/+2
| | | | | when we build for osmocom-bb cross-compilation, we don't have sockets nor netinet/in.h and thus NS/BSSGP make no sense...
* backtrace: don't use fprintf, but printf (for osmocom-bb)Harald Welte2012-09-081-1/+1
|
* BSSGP: print per-bvc flow control parameters on vtyHarald Welte2012-09-071-1/+12
|
* BSSGP: make bvc_ctx->fc a dynamic talloc allocationHarald Welte2012-09-071-5/+7
| | | | | this ensures that we can talloc the flow-control queue entries as siblings off the bvc_ctx.
* BSSGP flow-control: various fixesHarald Welte2012-09-072-10/+36
| | | | | | | * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
* libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branchHarald Welte2012-09-072-4/+225
| | | | | | | | This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
* BSSGP: fix unused variable compiler warningsHarald Welte2012-09-071-8/+2
|
* libosmogb: build without strict aliasing rulesHarald Welte2012-09-071-1/+1
| | | | | | This allows us to reliably do the trick with casting structures like libgb_msgb_cb to the msgb->cb[] array. Shamelessly stolen from the Linux kernel.
* libosmogsm: Back-port SMS related fixes from openbscHarald Welte2012-08-291-1/+10
| | | | | | | | This was fixed in 9c3dc90d16a40789081c84e46620f4d66689fec1 of openbsc.git, after the sms code had been migrated here: introduce HAVE_TM_GMTOFF_IN_TM Not all architectures have the tm.tm_gmtoff member. This fixes cygwin builds.
* GSM 04.08: Add support for parsing CSD related bearer capabilitiesHarald Welte2012-08-241-5/+90
| | | | Also adds a test case for both encoder and decoder of this IE
* gsm48_ie: annotate functions with chapter numbers from 04.08 specHarald Welte2012-08-241-29/+29
|
* import vty_cmd_string_from_valstr() from osmo-btsHarald Welte2012-08-201-0/+54
| | | | | This function is able to generate a VTY help string based on an array of 'struct value_string'.
* increaes libosmocgsm LIBVERSIN due to gsm_decode_lai() changeHarald Welte2012-08-031-1/+1
|
* serial: don't set O_NDELAY, as it is more or less O_NONBLOCKHarald Welte2012-08-031-1/+1
| | | | | Applications like osmocon will set O_NONBLOCK themselves or have it done indirectly by registering it with libosmocore/select.c code.
* gb: Make suspend_ref a plain uint8_t instead of a uint8_t*Holger Hans Peter Freyther2012-08-031-1/+1
| | | | | | The OpenSUSE build is not happy about the uint8_t to uint8_t* assignment. As the suspend_ref is a mandatory field we can make it a plain uint8_t. Increase the LIBVERSION as the ABI has changed.