summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* gsm48: Added 'Network Daylight Saving Time' info elementJacob Erlbeck2013-09-161-0/+1
| | | | | | | | This information element has been added to the MM Information message in GSM24.008. This patch adds it to the tlv_definition to keep the TLV parser from breaking. Ticket: OW#978
* vty: Allow vty_go_parent() in all nodes.Jacob Erlbeck2013-09-111-5/+25
| | | | | | | This patch removes an assertion of node > CONFIG_NODE and changes the function to handle all nodes properly. For the sake of completeness, the generic 'exit' command implementation is extended to work properly with all nodes, too.
* vty: Replace 'enum node_type' by 'int' for last_nodeJacob Erlbeck2013-09-101-1/+1
| | | | | In this case the last_node variable may hold values that are not in enum node_type, so int is used instead.
* vty: Add vty_install_default() and use for the vty nodesJacob Erlbeck2013-09-083-7/+16
| | | | | | | | | | | This adds the vty_install_default() function that is basically the install_default() function plus the registration of the commands 'exit' and 'end'. The latter is only provided in subnodes of ENABLED_NODE and CONFIG_NONE. The VTY test program is extended to check these commands. Ticket: OW#952
* vty: Refactored vty_go_parent(), 'end' and 'exit'Jacob Erlbeck2013-09-081-22/+35
| | | | | | Put all 'exit' logic into vty_go_parent() and replace the implementations of 'exit' and 'end' by generic ones that use vty_go_parent().
* vty: Rename is_config() to is_config_child()Jacob Erlbeck2013-09-081-3/+3
| | | | | The function is_config() returns 0 for CONFIG_NODE. Since that node is a config node, the function is renamed to resolve this.
* sms: Implement encoding the address as alphanumeric typeHolger Hans Peter Freyther2013-09-041-9/+21
| | | | | | The number of digits is the number of used octets times two (two digits per octet). The result has been successfully dissected by wireshark. It has not been tested with real phones.
* sms: Added comment about the gsm_7bit_alphabet tableJacob Erlbeck2013-08-121-2/+6
| | | | | The table structure is not intuitive, so this comment shall aid to understand this.
* sms: Added result buffer size parameter to 7bit conv funsJacob Erlbeck2013-08-123-59/+104
| | | | | | | | | | | | | The 7bit<->8bit encoding/decoding functions didn't check whether there is still enough space in the destination buffer. Therefore a buffer size parameter has been added to each of the functions which is used to truncate the output if the buffer is too small. In addition, the return value of the decoding functions has been changed to number of characters written (excluding \0), so this value is always equal to strlen(decoded). The old functions are still available as wrapper functions.
* lapd: Remove the double NULL check idiom with msgb_freeHolger Hans Peter Freyther2013-08-091-22/+13
| | | | | | | | | | | | | | if (ptr) msgb_free(ptr) extends to: if (ptr) talloc_free(ptr) And according to the talloc documentation a talloc_free(NULL) will not crash: "... Likewise, if "ptr" is NULL, then the function will make no modifications and returns -1."
* gsm: The LAPDm prim/structs changed, increment current versionHolger Hans Peter Freyther2013-08-091-1/+1
|
* Add special 7-bit encoding and decoding functions for USSD codingAndreas Eversberg2013-08-083-5/+38
| | | | | | | | | | | | | | | | | | | | | | | | Handling 7-bit coding is a little different for USSD, as TS 03.38 states: To avoid the situation where the receiving entity confuses 7 binary zero pad bits as the @ character, the carriage return or <CR> character shall be used for padding in this situation [...]. If <CR> is intended to be the last character and the message (including the wanted <CR>) ends on an octet boundary, then another <CR> must be added together with a padding bit 0. The receiving entity will perform the carriage return function twice, but this will not result in misoperation as the definition of <CR> [...] is identical to the definition of <CR><CR>. The receiving entity shall remove the final <CR> character where the message ends on an octet boundary with <CR> as the last character. Jacob has verified the fix with fakeBTS and the wireshark dissector. Fixes: OW#947 Reviewed-by: Jacob Erlbeck <jerlbeck@sysmocom.de>
* encoding: Provide an overload for the gsm_7bit_encode and a simple testHolger Hans Peter Freyther2013-08-082-2/+9
| | | | | | | This is required for encoding the SMS header using the alpha numeric rules. Reviewed-by: Jacob Erlbeck <jerlbeck@sysmocom.de>
* vty: Support multi-char separators and end stringsJacob Erlbeck2013-08-061-4/+5
| | | | | In vty_cmd_string_from_valstr() include the real string lengths of the sep and end arguments into the buffer size calculation.
* vty: Fix misusage of snprintf in vty/utils.cJacob Erlbeck2013-08-061-2/+2
| | | | | | | | | | | | | | | Compiled with ubuntu 1204 (precise), where -Wformat-security is enabled by -Wall. Test yields ok, but the current implementation doesn't properly support multi-character separators and end strings. So the test output is truncated. Addresses: utils.c: In function 'vty_cmd_string_from_valstr': utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security]
* vty: Fix logically dead code in the description handlingHolger Hans Peter Freyther2013-07-141-1/+1
| | | | | | | | | | The code most likely wanted to check the result of argv_concat. To do this we need to dereference the dptr. Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement "return 1; Fixes: Coverity CID 1040675
* gsm0808.c: Add TLV definition for LAYER3_HEADER_INFORMATIONDmitri Soloviev2013-07-111-0/+1
| | | | | This is required for osmo-bsc to parse Alcatel S-12 CIPHER MODE COMMAND in osmo-bsc.
* LAPD: Free resume/re-establishment msgb if it carries no contentAndreas Eversberg2013-07-101-2/+5
| | | | | | | | | lapdm.c takes the re-establishment message and forwards it to lapd_core.c, so we can assume that msgb is set at primitive. In case there is data in the re-establishment msg, it is moved into send_buffer. In case of no data (0 length), it must be freed. Fixes an issue spotted by Coverity Scan.
* gsm: Revert the gsm_7bit_encode changes as they are wrongHolger Hans Peter Freyther2013-07-072-30/+9
| | | | | | | | | | | | | | | This reverts commit f996b05dbddccb8e8788dd69777a4fedfa2373eb and 2b0cac4ef83137ee0bdd583aee877eac467abeab. A detailed explanation can be found here: http://lists.osmocom.org/pipermail/openbsc/2013-July/004737.html The short description is that: 1.) The API should return (as out parameter) the number of octets used. 2.) The handling for the <CR> encoding only applies to USSD and it is incomplete. On top of that it broke the SMS test.
* Fix: Handle returned length by gsm_7bit_encode correctlyAndreas Eversberg2013-07-061-9/+24
|
* Fix encoding of last character at 7bit encoding functionAndreas Eversberg2013-07-061-0/+6
| | | | | | To avoid the situation where the receiving entity confuses 7 binary zero pad bits as the @ character, the carriage return or <CR> character shall be used for padding in this situation.
* libosmogb: Add function to close NS instance without destroying itHolger Hans Peter Freyther2013-07-062-7/+13
|
* LAPDm: Allow sending unit data on DCCHAndreas Eversberg2013-07-061-10/+18
| | | | It is used to transfer PHYSICAL INFORMATION message to the MS.
* LAPDm: Fix re-establishment of datalinkAndreas Eversberg2013-07-061-5/+14
| | | | | | | | | | If the datalink fails or if handover or assignment to a new channel fails, it is re-establised by sending SABM again. The length of establish message is 0 in this case. The length is used to differentiate between re-establishment and contention resolution, which has to be handled differently. See TS 04.06 Chapter 5.4.2.1
* get_value_string: Null terminate after the call to snprintfHolger Hans Peter Freyther2013-07-041-0/+1
| | | | | | | It is impossible that the snprintf will fill the entire namebuf but just follow the idiom to make sure it is null terminated. Related: Coverity CID 1040676
* vty: Attempt to fix various meam leaks in the VTY lookup codeHolger Hans Peter Freyther2013-07-031-0/+3
| | | | | | | | | | These routines were not freeing vectors used for the lookup. On review it is fixing another path not detected by coverity. The danger is a double free in tab completion now. It is difficult to test this. Fixes: Coverity CID 23037, CID 23038
* gsm0408: Avoid unaligned memory access in gsm48_generate_mid_from_tmsiHolger Hans Peter Freyther2013-07-031-2/+2
| | | | | | | | The &buf[3] is unlikely to be aligned properly. Use memcpy instead of an assignment. Add a small testcase that verifies that I didn't mess up the conversion. Alignment trap: osmo-nitb (3293) PC=0x492b7094 Instr=0xe5803003 Address=0xbeb259db FSR 0x801
* strrb: Remove a tautology from the codeHolger Hans Peter Freyther2013-07-031-1/+1
| | | | | | | | This already came up during review but now that Coverity complains about it as well, let us just remove it. The variable is unsigned so it can never be < 0. Fixes: Coverity CID 1040669.
* BSSGP: prevent divide-by-zero in flow controlHarald Welte2013-06-291-10/+33
| | | | | | | If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
* introduce gsm0808_create_reset_ack()Harald Welte2013-06-291-0/+13
|
* lapd_core: msgb_trim() the L2 padding from ESTABLISH.indHarald Welte2013-06-181-2/+3
| | | | | | | | When a SABM(E) frame arrives, we have to trim the L2 padding (0x2b for gsm) before handing the data off to L3, just like we do with I frames. Also, we should use mggb_trim() or even msgb_l3trim() instead of manually fiddling with msgb->length and ->tail pointers.
* misc: Fix the spelling of frame in the RLM cause stringsHolger Hans Peter Freyther2013-06-111-1/+1
|
* gsm_utils: refer to ETSI TS 05.08 instead of TS 08.05Bhaskar2013-05-231-2/+2
|
* lapd: Set the tx_hist to NULL after freeing itHolger Hans Peter Freyther2013-05-081-0/+1
| | | | | Make detecting use after free of the tx_hist easy and set the variable to NULL after talloc_free has been freed.
* Fix of potential memory leaks at lapdm.cAndreas Eversberg2013-04-061-4/+17
|
* Fix: LAPDm contention resoltion must acknowledge subsequent SABMAndreas Eversberg2013-04-061-2/+8
| | | | | | | | | After reception of SABM, the network responds with UA and enters the establised multiframe state. If UA is not received by mobile, the SABM is transmitted again, and the network must respond with UA again, unless it is from a different mobile. Add LAPDm collision test (contention resolution on network side).
* gprs_ns: Allow to set the DSCP for the UDP socket.Holger Hans Peter Freyther2013-03-253-0/+24
| | | | Allow to tag the NS service with a custom DSCP.
* logging_vty: Fix segfault un unused entries in log_info_cat array of appHarald Welte2013-03-191-0/+4
|
* Revert "Follow up fix for the log level "everything""Harald Welte2013-03-191-3/+0
| | | | This reverts commit a6428d2376034d619f342897d3ce415b3f9a3584.
* Revert "Fix log level "everything" and make it equal to "debug""Harald Welte2013-03-191-1/+1
| | | | This reverts commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5.
* application: don't ignore SIGHUP but do config file reopen.Harald Welte2013-03-181-1/+6
|
* logging: add new log_targets_reopen() functionHarald Welte2013-03-181-0/+20
| | | | | This function will re-open all existing log files in the application, praticularly useful for SIGHUP handlers in case of logrotate
* gsm_septets2octets(): Input parameter should be constHarald Welte2013-03-131-1/+2
|
* logging_vty: Print 'log filter all' info in 'show logging vty'Harald Welte2013-03-131-0/+6
| | | | | When we print information about the current logging configuration, it makes sense to also print information about the log filters.
* cygwin: Link many libraries with -no-undefined to create a dllHolger Hans Peter Freyther2013-03-034-5/+5
| | | | | | Only the Gb library relies on having undefined references to a symbol that needs to be provided by the host application. For all other libraries we can link with -no-undefined.
* codec: Fix the GSM 06.20 ordering tablesSylvain Munaut2013-03-011-41/+41
| | | | | | | | | | Seems the script I used to parse those had a bug where range of bits in the 'decreasing' direction ( like 6..0 ) were not processed properly. Thanks to Andreas for noticing this ! Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* Follow up fix for the log level "everything"Holger Hans Peter Freyther2013-02-271-0/+3
| | | | | | | | | | | | Commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5 made "EVERYTHING" map to LOGL_DEBUG but when writing out the configuration the following would be written: logging level all unknown 0x0 This happend because no string was found for the value 0. Address it by adding a legacy check for 0 and write out the str from the index 0. Currently this is "EVERYTHING".
* Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi2013-02-274-6/+352
| | | | | | | The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
* Revert "Added a ring buffer log target to store the last N log messages."Holger Hans Peter Freyther2013-02-274-351/+6
| | | | | | | I noticed some more issues and it is the easiest to revert and include the fixed version. This reverts commit 73377229bb33ab79682ce4b126a63602d13304ad.
* Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi2013-02-274-6/+351
| | | | | | | The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 23:39:29 +0000