summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* include: Switch to #pragma once patternSylvain Munaut2014-06-164-16/+4
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsm0411_smr: Fix the size of the arrayHolger Hans Peter Freyther2014-05-231-1/+1
| | | | | | | The code is lacking a "," at the end of a string and we ended up doing string concatination instead of having an invalid state. Fixes Coverity CID 1206564
* gsm0411_smr: Make the look-up table staticHolger Hans Peter Freyther2014-05-231-1/+1
|
* timer: Use the now parameter when it is not NULLHolger Hans Peter Freyther2014-05-231-3/+3
| | | | | | | | The code would have used an uninitialized current_time in case "now" was not NULL. As now is const and timersub expects a non const parameter I decided to copy now into current_time. Fixes: CID #1040661
* Fix introducing osmocom speficic OML attributesHarald Welte2014-05-192-0/+8
| | | | | | | | | | | | | | | | | | | Rename NM_ATT_O_REDUCEPOWER to NM_ATT_OSMO_REDUCEPOWER, which makes it more clear that this is an osmcoom specific attribute. Also, we cannot simply overload 0x01 as an already defined OML attribute. The problem is quite simple: When we use abis_nm_att_tlvdef during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL, which is defined as { TLV_TYPE_FIXED, 3 }. So instead, we need to introduce a new abis_nm_osmo_att_tlvdef[], which has to be patched into abis_nm_att_tlvdef[] by the means of tlv_def_patch(), exactly how we do it for bs-11 and nanobts specific attributes. I'm using 0xfe for the attribute, as 0xfe doesn't overlap with the IPA specific attribues (and we might want to combine/merge the 12.21 plus IPA plus osmocom spefici attributes)
* select: Fix english in commentHolger Hans Peter Freyther2014-05-151-1/+1
|
* backtrace: Speculative fix for FreeBSD10.0 and execinfo.hHolger Hans Peter Freyther2014-04-171-1/+2
| | | | | | | FreeBSD 10.0 ships an execinfo.h but one needs to link to an additional library for the backtrace functions. Check if there is a backtrace symbol in libexecinfo and if so link to that library.
* Release: Prepare the release of 0.6.6Holger Hans Peter Freyther2014-03-311-1/+1
|
* src/socket: Adding unix domain socket supportÁlvaro Neira Ayuso2014-03-261-0/+102
| | | | | | Added some function for adding the unix domain socket support. Signed-off-by: Alvaro Neira Ayuso <anayuso@sysmocom.de>
* sms: Add missing brackets in the relative validity time calculation.Alexander Chemeris2014-03-261-3/+3
|
* gsm/lapdm: Prevent LAPD tx_queue from filling up in polling modeDaniel Willmann2014-03-262-0/+27
| | | | | | | If LAPDm receives an I-Frame while there already is an I-Frame in the tx_queue the code generates an additional RR (to acknowledge the received I-Frame). Instead, N(R) of the I-Frame in the tx_queue should be updated to ACK the data.
* lapdm: Make lapdm_datalink_for_sapi publicDaniel Willmann2014-03-262-3/+4
| | | | | This API allows you to get the lapdm_datalink for a SAPI. It's needed in the lapdm_test, so make it public.
* lapd: Improve log message and mention the SAPI the dl is onHolger Hans Peter Freyther2014-03-161-2/+2
| | | | | | | When debugging an issue that involves SAPI=0 and SAPI=3 the log file does not have enough context. Add the SAPI to this message so we at least understand which SAPI we are talking about.
* ladpm: Fix msgb handling and SAPI=3 establishment delayJacob Erlbeck2014-03-101-27/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently it takes 3s to establish a SAPI 3 SACCH connection with osmo-bts. This is due to the fact, that a broken SABME request is sent first and and is ignored by the MS. Then, after a T200 timeout (2s) the SABME command is sent again (this time correctly) and answered by the MS. The first SABME message is broken (it has a length field of 3 and ends with 3 bytes from the tail of the original RSL message), because of it is expected throughout lapdm.c that msg buffers containing RSL have msg->l2h == msg->data. Some abis input drivers fulfill this but IPA doesn't, thus the 3 bytes of the IPA header are still part of the msg and confuse length computation. Since internal fields of the msg are modified directly, this is difficult to see. This patch adds a new function msgb_pull_to_l3() that explicitely skips over all headers prepending L3 and therefore resets l1h and l2h. This function is then used instead of msgb_pull_l2h() which only worked correctly when msg->l2h == msg->data. In addition, code manipulating msg->tail and msg->len directly has been replaced by calls to msgb_trim(). Note that this patch does not fix all issues of this case in the LADP related code. Ticket: SYS#192 Sponsored-by: On-Waves ehf
* msgb: Add msgb_hexdump() functionJacob Erlbeck2014-03-041-0/+49
| | | | | | | | | | | | This function works like osmo_hexdump() and returns a static buffer containing hex bytes along with markers for the layers. Note that it uses osmo_hexdump() internally, thus a call to msgb_hexdump() invalidates the buffer that has been returned by an earlier call to osmo_hexdump(). In short: don't mix them in a single call printf(). Sponsored-by: On-Waves ehf
* lapd: Use the right struct for the talloc_zero_array callHolger Hans Peter Freyther2014-02-091-2/+2
| | | | | | I saw this while playing with talloc pools and wondered why lapd_core is creating a log_info. Use the right struct for the array.
* sms: The msg_ref is passed from the outside so remove the wrong fixmeHolger Hans Peter Freyther2014-02-081-1/+1
|
* lapdm: Fix typo in the commentHolger Hans Peter Freyther2014-01-231-1/+1
|
* gsm/gsm48ie: Fix range 256 W[i] decodingJacob Erlbeck2014-01-131-4/+4
| | | | | | | | | Currently w[14]/w[15] and w[18]/w[19] are swapped in range 256 format decoding in gsm48_decode_freq_list(). This patch fixes this. Sponsored-by: On-Waves ehf
* sms: Fix gsm_7bit legacy functions return valueJacob Erlbeck2014-01-091-6/+11
| | | | | | | | | | | | | | The legacy 7bit conversion functions (those without the '_n_' in the name) gave wrong return values on 64 bit platforms due to unproper signed/unsigned conversions and the usage of SIZE_MAX. This patch fixes this by using a smaller max size (see GSM_7BIT_LEGACY_MAX_BUFFER_SIZE, currently set to 64k) for the legacy wrappers and by using unsigned int for max_septets. In addition, there are tests now that check the return values of legacy encoding and decoding. Sponsored-by: On-Waves ehf
* abis: Use the right return value for abis_nm_pchan4chcombHolger Hans Peter Freyther2014-01-021-1/+1
| | | | | | | | | abis_nm_pchan4chcomb will return a pchan for a given channel combination but returned a value of the channel combination. Fix it to return the physical channel combination. Fixes: Coverity CID 1040767
* utils: Greatly improve performance of osmo_hexdump routinesNils O. Selåsdal2014-01-021-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | In the osmo-bts and libosmo-abis code the hexdump routine is used for every incoming/outgoing packet (including voice frames) and the usage of snprintf showed up inside profiles. There is a semantic change when more than 4096 characters are used. The code will now truncate at byte boundaries (and not nibbles). Code: static const int lengths[] = { 23, 1000, 52 }; char buf[4096]; int i; for (i = 0; i < 30000; ++i) char *res = osmo_hexdump(buf, lengths[i & 3]); Results: before: after: real 0m3.233s real 0m0.085s user 0m3.212s user 0m0.084s sys 0m0.000s sys 0m0.000s
* logging: Copy the filter_fn and fix the IMSI filter in OpenBSCHolger Hans Peter Freyther2013-12-291-0/+1
| | | | | | | The filter_fn has not been copied into the new structure breaking the imsi and other filters in OpenBSC. Looking at the code we should also introduce a callback for the reset of the context so we could use subscr_get/subscr_put on the subscriber structure.
* Refactor COMP128v23 implementation and add test suitMax2013-12-072-38/+29
|
* gb: Remove comment about ABI changes from the MakefileHolger Hans Peter Freyther2013-11-221-3/+0
| | | | | | Okay. this comment thing has not worked (I totally forgot about it). I think either we try to find ABI breakages with tools or we use #error macros and check for a version...
* gprs: Fix VTY NSVC initialisation bug by changing gprs_nsvc_create()Jacob Erlbeck2013-11-111-3/+3
| | | | | | | | | | | | | | | | Currently the field nsvci_is_valid is set to 0 in the NSVC object returned by gprs_nsvc_create(). This was a semantic change probably introduced by commit 5e6d679d. As a result, NSVC created via the VTY have this flag set to 0 causing RESET_ACK messages to be rejected. This patch changes the default behaviour of gprs_nsvc_create() to always set this flag. So it must be set to 0 explicitely if needed which is more intuitive and thus less error prone. It fixes breaking connections from the Gbproxy to the SGSN. Ticket: OW#874 Sponsored-by: On-Waves ehf
* implement COMP128 version 2 and 3 A3/A8 algorithmKevin Redon2013-11-033-5/+240
| | | | simple copy into C from reversed code from www.hackingprojects.net
* gprs: Ignore NS RESET_ACK and ALIVE_ACK without RESETJacob Erlbeck2013-10-301-0/+17
| | | | | | | | | | | Currently those messages are answered by a NS_STATUS message when received on an uninitialised (no NS_RESET hat been seen yet) NS_VC which violates GPP TS 08.16 7.3.1 and 7.4.1. This patch adds checks to gprs_ns_vc_create() and eventually returns before the error NS_STATUS message is generated. Sponsored-by: On-Waves ehf
* gprs: Address coverity warning for gprs_ns_tx_status resultHolger Hans Peter Freyther2013-10-251-8/+10
| | | | | | Add a #define for the check and use this in this path as well. Fixes: Coverity CID 1103092
* gprs: Address coverity warning on unchecked return of gprs_ns_tx_reset_ackHolger Hans Peter Freyther2013-10-251-1/+5
| | | | Fixes: Coverity CID 1111545
* gprs: Address coverity warning on unchecked return of gprs_ns_tx_statusHolger Hans Peter Freyther2013-10-251-1/+4
| | | | | | | We could consider creating a CHECK MACRO that will print a message in case of a tx failure. Fixes: Coverity CID 1111544
* gprs: Make sure that the buf is NULL terminated at the endHolger Hans Peter Freyther2013-10-251-0/+1
| | | | Fixes: Coverity CID 1107253
* gb: Create new NSVC object instead of patching the NSVCIJacob Erlbeck2013-10-241-4/+12
| | | | | | | | | When a RESET is received on the same link with a different NSVCI from a BSS on a dynamically created NS connection do not patch the nsvc object but create a new one instead. Thus the NSVCI is never modified at a nsvc object after the NS-VC has been established. Sponsored-by: On-Waves ehf
* gb: Fix RESET handling with changing NSEIJacob Erlbeck2013-10-241-28/+40
| | | | | | | | | This modifies the NS stack's behavior to accept RESET and RESET_ACK NSEI changes for NS-VC dynamically created by RESET messages from BSSes. This feature is not used for NS-VC configured via VTY or NS-VC to a SGSN. Sponsored-by: On-Waves ehf
* gb: Fix NS RESET/RESET_ACK abnormal casesJacob Erlbeck2013-10-241-56/+215
| | | | | | | | | | | | | | | | This changes the implementations for the reception of RESET and RESET_ACK to be compatible with 3GPP TS 08.16, 7.3.1: - Just send a RESET_ACK with correct values back to the SGSN when a RESET with an invalid NSVCI or NSEI has been received. - Check RESET_ACK for matching NSEI and NSVCI. - Ignore unexpected RESET_ACKs. In addition, use RESET_ACK from a BSS to update the BSS source address based on the NSVCI to be tolerant with changing UDP source addresses/ports. Sponsored-by: On-Waves ehf
* gb: Fix gprs_nsvc_delete() to free ctr groupJacob Erlbeck2013-10-241-0/+1
| | | | | | | | | | | | | | | | | | | | This fixes a SEGV error that happens the next time the statistics are updated. Addresses: Program terminated with signal 11, Segmentation fault. #0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at rate_ctr.c:107 107 for (i = 0; i < grp->desc->num_ctr; i++) { #0 0xb7711fa5 in rate_ctr_group_intv (grp=<optimized out>) at rate_ctr.c:107 #1 rate_ctr_timer_cb (data=0x0) at rate_ctr.c:129 #2 0xb770ec59 in osmo_timers_update () at timer.c:243 #3 0xb770ef7a in osmo_select_main (polling=0) at select.c:133 #4 0x08049987 in main (argc=3, argv=0xbfba8084) at gb_proxy_main.c:306 Sponsored-by: On-Waves ehf
* gb/vty: Fix the VTY node string for L_NS_NODEJacob Erlbeck2013-10-241-1/+1
| | | | | | | Use 'config-ns' instead of plain 'ns' and append a blank after the '#' to make the vty python test script work. Sponsored-by: On-Waves ehf
* gb/vty: Perform NS-VC operations based on NS-VCIJacob Erlbeck2013-10-241-5/+15
| | | | | | | | | This adds a 'nsvc nsvci <0-65535> (block|unblock|reset)' vty command. It selects the NS-VC based on the nsvci instead of using the first with a matching NSEI, like it is done when the 'nsei' keyword is used instead. Sponsored-by: On-Waves ehf
* gb: Fix gprs_active_nsvc_by_nsei()Jacob Erlbeck2013-10-171-2/+2
| | | | | | | The state matching condition is inverted. This is corrected by this fix. Sponsored-by: On-Waves ehf
* release: Prepare the 0.6.4 release of libosmocoreHolger Hans Peter Freyther2013-10-151-1/+1
| | | | New interfaces and ABI incompatible changes in the GB library
* ussd: Fix text of RELEASE COMPLETEAlexander Huemer2013-10-151-1/+1
| | | | | | Before the assigned value (0xFF) was truncated, reg->text[0] is of type char. A corresponding test for the same value in openbsc could only fail.
* gb: Fix gprs_ns_rx_reset to not create NS-VC duplicatesJacob Erlbeck2013-10-151-74/+149
| | | | | | | | | | | | | | | | | | | | | | | | | Under special circumstances (see below) receiving a NS-RESET leads to duplicated NS-VC entries. This happens when the source port of a NS-VC changes to a new one that has already been used by another NS-VC. This patch changes gprs_ns_rx_reset() to check for this case and to use the existing NS-VC object. The NS-VC object that was associated with the source address before is detached from this source but kept in the NS-VC list so that it can be reattached when a correspondent NS-RESET is received later on. Meanwhile it will have a cleared link layer address which will not match a real link info. A new counter NS_CTR_REPLACED is incremented each time when the NS-VC object is replacing another one. A new signal S_NS_REPLACED is added which gets dispatched in this case, too. Another new counter NS_CTR_NSEI_CHG is incremented each time when the NSEI of a NS-VC object (with fixed NSVCI) changes. Ticket: OW#874 Sponsored-by: On-Waves ehf
* gb: Add functions to access the LL part of the NS-VC objectsJacob Erlbeck2013-10-152-6/+40
| | | | | | | | Adds the functions gprs_ns_ll_copy() and gprs_ns_ll_clear(). Renames gprs_ns_format_peer() to gprs_ns_ll_str(). All of these functions uniformly access the link layer part within the NS-VC objects. Sponsored-by: On-Waves ehf
* gb: When sending on a NS-VC group use the first active NS-VCJacob Erlbeck2013-10-141-18/+29
| | | | | | | | | | | | Currently this first NS-VC with a matching NSEI is always used to send a UNITDATA message via gprs_ns_sendmsg(). If the NS-VC found is either dead or blocked, an error is returned. This patch changes to code to skip blocked or dead NS-VCs while searching and return the error if no usable NS-VC is found. This makes it possible to have several NS-VCs per connection group. Sponsored-by: On-Waves ehf
* tests/gb: Show invoked signals in test outputJacob Erlbeck2013-10-111-0/+1
| | | | | | | Register an osmo signal handler to print a short notice about every SS_L_NS signal that is generated while processing the tests. Sponsored-by: On-Waves ehf
* vty: Make vty_event dispatch signals and use it in the testcaseHolger Hans Peter Freyther2013-10-101-1/+13
| | | | | | | | | The testcase didn't work on Ubuntu 12.04 because vty_create will directly call vty_event (e.g. not through the plt). This means that the approach to override vty_event in the testcase failed. Use the signal interface of libosmocore and make the testcase use it. The signals can be generally useful as well.
* gb: Use the NS-VCI to find an existing NS-VCJacob Erlbeck2013-10-081-4/+4
| | | | | | | | | | | | | | | | Currently when a NS-RESET is recevied over a link that has not yet been associated with a NS-VC, the NSEI is used to find an existing NS-VC. If one is found, the reset procedure is initiated. This behaviour is not conformant with 3GPP TS 08.16 (see chapter 4.2.3) which allows to use several NS-VC between two endpoints in parallel. The patch changes the implementation to use the NSVCI instead of the NSEI to search for an existing NS-VC object. Ticket: OW#874 Sponsored-by: On-Waves ehf
* gb: Fix NS-RESET response message orderJacob Erlbeck2013-10-081-5/+7
| | | | | | | | | | | | | | According to 3GPP TS 08.16, 7.3 "Reset procedure" the entity receiving a NS-RESET PDU responds with a NS-RESET-ACK and 'then' starts the test procedure which essentially means, that a NS-ALIVE gets sent and a timer is started. Currently the NS-ALIVE is sent before the NS-RESET-ACK. This patch fixes the implementation by reversing the order in which these messages are sent. Sponsored-by: On-Waves ehf
* gb: Separate nsvc creation from NS message processingJacob Erlbeck2013-10-081-55/+144
| | | | | | | | | | | | This patch refactors gprs_ns_rcvmsg() by moving the parts relevant to the NS messages into the new functions gprs_ns_vc_create() (nsvc object creation) and gprs_ns_process_msg() (main NS automaton). These do not contain code that directly depends on the link layer (they call other functions that still do). This reduces the gprs_ns_rcvmsg() function to calling these two functions and optionally setting up the link layer specific fields of the nsvc. Sponsored-by: On-Waves ehf
* gsm48: Added 'Network Daylight Saving Time' info elementJacob Erlbeck2013-09-161-0/+1
| | | | | | | | This information element has been added to the MM Information message in GSM24.008. This patch adds it to the tlv_definition to keep the TLV parser from breaking. Ticket: OW#978
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 15:09:37 +0000