summaryrefslogtreecommitdiffstats
path: root/contrib/verify_value_string_arrays_are_terminated.py
Commit message (Collapse)AuthorAgeFilesLines
* contrib: add script to find unterminated value_string arraysNeels Hofmeyr2017-03-161-0/+33
Unterminated value_string arrays are dangerous since get_value_string() and get_string_value() need to know where the struct ends. If the terminator is missing, they might run through and return arbitrary memory locations. Employ some regexes to find such unterminated value string arrays and return nonzero if any are found. This can be used in our jenkins build jobs to avoid committing unterminated value_string arrays. In fact I've found one in current libosmocore: gsm0808_bssap_names in gsm/gsm0808.c, fixed in a separate patch. Change-Id: I2bc93ab4781487e7685cfb63091a489cd126b1a8