summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add osmo_get_macaddr() function to obtain etherent mac addressHarald Welte2014-08-182-0/+27
| | | | | This used to be private in osmo-bts/common/abis.c, where it really didn't belong.
* osmocore: Add function osmo_macaddr_parse() to parse ETH MAC addressHarald Welte2014-08-184-1/+34
|
* TLV: add TLVP_PRES_LEN() definition to check for existance + minimum lengthHarald Welte2014-08-181-0/+3
| | | | | This is an import from osmo-bts where it was introduced in 6b561bb7ba5f10c5fd96542a7e42de2822352a67
* ipaccess.h: Add IPAC_PROTO_EXT_ORC for OML Router ControlHarald Welte2014-08-181-0/+1
|
* abis_nm: add abis_nm_msg_disc_names[] value_stringHarald Welte2014-08-173-0/+11
|
* abis_nm: introduce abis_nm_{osmo,ipa}_magic[]Harald Welte2014-08-173-0/+8
| | | | ... used to be oml_{osmo,ipa}_magic in osmo-bts
* gprs-ns: Re-initialize the list head and free the unknown_nsvcHolger Hans Peter Freyther2014-07-071-0/+3
| | | | | | | | | | | | | | | | | Fix re-initialize issue of the GPRS NS. This was found while working on the GB Proxy tests. ==27800== Invalid write of size 4 ==27800== at 0x403C263: rate_ctr_group_alloc (linuxlist.h:65) ==27800== by 0x4050974: gprs_nsvc_create (gprs_ns.c:209) ==27800== by 0x405320D: gprs_ns_instantiate (gprs_ns.c:1330) ==27800== by 0x804B212: main (gbproxy_test.c:797) ==27800== Address 0x434173c is 52 bytes inside a block of size 784 free'd ==27800== at 0x4029DA8: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==27800== by 0x4041BBD: _talloc_free (talloc.c:609) ==27800== by 0x40432B2: talloc_free (talloc.c:578) ==27800== by 0x40532D3: gprs_ns_destroy (gprs_ns.c:1363) ==27800== by 0x804B1FE: main (gbproxy_test.c:791)
* write_queue: Use EBADF instead of EBABDFD for portabilityHolger Hans Peter Freyther2014-07-013-5/+5
| | | | | EBADFD is linux specific while EBADF is POSIX. Fix the build on FreeBSD and use EBADF throughout the file.
* vty: Avoid use-after-free in VTY telnet interfaceDaniel Willmann2014-06-222-4/+4
| | | | | | If the read callback closes the connection conn is already freed so we can't derefernce it. Instead return -EBADFD in the read function if it closed the connection and check for that.
* osmo-auc-gen: Fix compiler warnings about aliasingHolger Hans Peter Freyther2014-06-221-4/+7
| | | | | | | | | | | | | | | | | | | I ran "./utils/osmo-auc-gen -2 -a COMP128v1" and verified that the RAND doen't look empty Fixes: osmo-auc-gen.c: In function ‘main’: osmo-auc-gen.c:219:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] *(uint32_t *)&_rand[0] = rand(); ^ osmo-auc-gen.c:220:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] *(uint32_t *)(&_rand[4]) = rand(); ^ osmo-auc-gen.c:221:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] *(uint32_t *)(&_rand[8]) = rand(); ^ osmo-auc-gen.c:222:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] *(uint32_t *)(&_rand[12]) = rand();
* write_queue: Avoid possible use-after-free if fd is read-/writableDaniel Willmann2014-06-221-5/+18
| | | | | | | | | If the FD is both readable and writable and the read callback closes the connection (and frees the surrounding structure) we shouldn't call the write callback (or check anything else in the read fd). With this patch callback functions can return -EBADFD if they don't want the FD to be handled any more.
* update TS 08.08 header + TLV definitions to TS 48.008 / 11.7.0Harald Welte2014-06-212-18/+151
| | | | | | | | | | This adds support for A-over-IP and LCLS related message/IEI definitions. Old definitions are in decimal, which is very hard (at least for me) to compare with the binary tables in the spec. Hex is much easier to manually compare for completeness/correctness. I didn't touch the existing definitions, but think they should move to hex, too.
* update gsm_08_08.h to Release 11Harald Welte2014-06-211-1/+119
|
* core/bitXXgen: Don't do 'return' in functions returning voidSylvain Munaut2014-06-161-2/+2
| | | | | | ISO C forbids 'return' with expression, in function returning void Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* core/bitXXgen: Use explicit cast of void* to uint8_tSylvain Munaut2014-06-161-4/+6
| | | | | | Turns out we use this header in C++ code ... Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* tests/bits: Make sure all 'inline' are also staticSylvain Munaut2014-06-161-17/+43
| | | | | | Not doing so seems to break the BSD build Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsm: Add Kasumi cipher implementationSylvain Munaut2014-06-169-4/+397
| | | | | Submitted-by: Max <max.suraev@fairwaves.co> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* bits: Add left circular shift functionMax2014-06-161-0/+10
| | | | | Submitted-by: Max <max.suraev@fairwaves.co> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* Add missing entry in .gitignore for utils_testMax2014-06-161-0/+1
| | | | | Submitted-by: Max <max.suraev@fairwaves.co> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* core: Add generic LE/BE load/store uint type convertors and use them in msgbMax2014-06-167-12/+377
| | | | | Submitted-by: Max <max.suraev@fairwaves.co> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* include: Switch to #pragma once patternSylvain Munaut2014-06-1688-351/+88
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsmtap: add LTE defines to GSMTAP v2Max2014-06-151-1/+10
| | | | | Submitted-by: Max <max.suraev@fairwaves.co> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* build: Add .version to EXTRA_DISTSylvain Munaut2014-06-151-1/+1
| | | | | | | | | This is required to make distcheck work and apparently that's the "good way" to do it. See http://comments.gmane.org/gmane.comp.lib.gnulib.bugs/27780 Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsm0411_smr: Fix the size of the arrayHolger Hans Peter Freyther2014-05-231-1/+1
| | | | | | | The code is lacking a "," at the end of a string and we ended up doing string concatination instead of having an invalid state. Fixes Coverity CID 1206564
* gsm0411_smr: Make the look-up table staticHolger Hans Peter Freyther2014-05-231-1/+1
|
* timer: Use the now parameter when it is not NULLHolger Hans Peter Freyther2014-05-231-3/+3
| | | | | | | | The code would have used an uninitialized current_time in case "now" was not NULL. As now is const and timersub expects a non const parameter I decided to copy now into current_time. Fixes: CID #1040661
* abis_nm: Add the abis_nm_osmo_att_tlvdef to the abis headerÁlvaro Neira Ayuso2014-05-201-0/+1
| | | | | | | Avoid compiler warnings and declare the presence of the new tlv_description. Signed-off-by: Alvaro Neira Ayuso <anayuso@sysmocom.de>
* Fix introducing osmocom speficic OML attributesHarald Welte2014-05-193-1/+11
| | | | | | | | | | | | | | | | | | | Rename NM_ATT_O_REDUCEPOWER to NM_ATT_OSMO_REDUCEPOWER, which makes it more clear that this is an osmcoom specific attribute. Also, we cannot simply overload 0x01 as an already defined OML attribute. The problem is quite simple: When we use abis_nm_att_tlvdef during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL, which is defined as { TLV_TYPE_FIXED, 3 }. So instead, we need to introduce a new abis_nm_osmo_att_tlvdef[], which has to be patched into abis_nm_att_tlvdef[] by the means of tlv_def_patch(), exactly how we do it for bs-11 and nanobts specific attributes. I'm using 0xfe for the attribute, as 0xfe doesn't overlap with the IPA specific attribues (and we might want to combine/merge the 12.21 plus IPA plus osmocom spefici attributes)
* protocol/gsm_12_21.h: Add the Manufacturer Attribute ID O_REDUCEPOWER.Álvaro Neira Ayuso2014-05-151-0/+2
| | | | Signed-off-by: Alvaro Neira Ayuso <anayuso@sysmocom.de>
* select: Fix english in commentHolger Hans Peter Freyther2014-05-151-1/+1
|
* backtrace: Speculative fix for FreeBSD10.0 and execinfo.hHolger Hans Peter Freyther2014-04-172-1/+5
| | | | | | | FreeBSD 10.0 ships an execinfo.h but one needs to link to an additional library for the backtrace functions. Check if there is a backtrace symbol in libexecinfo and if so link to that library.
* Release: Prepare the release of 0.6.6Holger Hans Peter Freyther2014-03-315-5/+10
|
* src/socket: Adding unix domain socket supportÁlvaro Neira Ayuso2014-03-262-0/+108
| | | | | | Added some function for adding the unix domain socket support. Signed-off-by: Alvaro Neira Ayuso <anayuso@sysmocom.de>
* sms: Add missing brackets in the relative validity time calculation.Alexander Chemeris2014-03-261-3/+3
|
* Merge remote-tracking branch 'daniel/lapdm-desync'Holger Hans Peter Freyther2014-03-268-12/+300
|\ | | | | | | | | | | | | This should fix long delays when sending a long SMS on an encrypted channel. It is the most minimal change to the polling mode. One option we discussed internally is to queue a higher level representation and generate the actual LAPDm frames later.
| * gsm/lapdm: Prevent LAPD tx_queue from filling up in polling modeDaniel Willmann2014-03-266-17/+39
| | | | | | | | | | | | | | If LAPDm receives an I-Frame while there already is an I-Frame in the tx_queue the code generates an additional RR (to acknowledge the received I-Frame). Instead, N(R) of the I-Frame in the tx_queue should be updated to ACK the data.
| * tests/lapd: Add a testcase to check for LAPDm sync issuesDaniel Willmann2014-03-262-9/+272
| | | | | | | | Regression test for LAPDm recording the current state
| * lapdm: Make lapdm_datalink_for_sapi publicDaniel Willmann2014-03-263-3/+6
|/ | | | | This API allows you to get the lapdm_datalink for a SAPI. It's needed in the lapdm_test, so make it public.
* sms_test: Do not crash on logging.Alexander Chemeris2014-03-201-0/+8
|
* lapd: Improve log message and mention the SAPI the dl is onHolger Hans Peter Freyther2014-03-161-2/+2
| | | | | | | When debugging an issue that involves SAPI=0 and SAPI=3 the log file does not have enough context. Add the SAPI to this message so we at least understand which SAPI we are talking about.
* sms: Fix typo in a macros name: GSM340_SMS_RESSERVED -> GSM340_SMS_RESERVED.Alexander Chemeris2014-03-121-1/+1
|
* Merge branch 'jerlbeck/fixes/ladp-sms'Holger Hans Peter Freyther2014-03-105-59/+165
|\
| * ladpm: Fix msgb handling and SAPI=3 establishment delayJacob Erlbeck2014-03-103-31/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently it takes 3s to establish a SAPI 3 SACCH connection with osmo-bts. This is due to the fact, that a broken SABME request is sent first and and is ignored by the MS. Then, after a T200 timeout (2s) the SABME command is sent again (this time correctly) and answered by the MS. The first SABME message is broken (it has a length field of 3 and ends with 3 bytes from the tail of the original RSL message), because of it is expected throughout lapdm.c that msg buffers containing RSL have msg->l2h == msg->data. Some abis input drivers fulfill this but IPA doesn't, thus the 3 bytes of the IPA header are still part of the msg and confuse length computation. Since internal fields of the msg are modified directly, this is difficult to see. This patch adds a new function msgb_pull_to_l3() that explicitely skips over all headers prepending L3 and therefore resets l1h and l2h. This function is then used instead of msgb_pull_l2h() which only worked correctly when msg->l2h == msg->data. In addition, code manipulating msg->tail and msg->len directly has been replaced by calls to msgb_trim(). Note that this patch does not fix all issues of this case in the LADP related code. Ticket: SYS#192 Sponsored-by: On-Waves ehf
| * lapd/test: Check for empty ACCH queue, tooJacob Erlbeck2014-03-041-0/+2
| | | | | | | | | | | | | | This just adds a single test to verify that the ACCH queue is actually empty. Sponsored-by: On-Waves ehf
| * lapd/test: Extend test case to test msgs having data before l2hJacob Erlbeck2014-03-042-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since e.g. the IPA input driver leaves it's specific header in front of msg->l2h, so that msg->l2h != msg->data. The lapdm code does not expect this at least in rslms_rx_rll_est_req(). This patch modifies the test program to add a dummy L1 header to generated messages (unless the test would abort when doing so). Note that the ok file reflects the current state which is not correct. Sponsored-by: On-Waves ehf
| * lapd/test: Show dequeued messagesJacob Erlbeck2014-03-042-32/+72
| | | | | | | | | | | | This adds and uses a wrapper for lapdm_phsap_dequeue_prim() that prints information about the message that has been taken from the queue.
| * msgb: Add msgb_hexdump() functionJacob Erlbeck2014-03-042-0/+50
|/ | | | | | | | | | | | This function works like osmo_hexdump() and returns a static buffer containing hex bytes along with markers for the layers. Note that it uses osmo_hexdump() internally, thus a call to msgb_hexdump() invalidates the buffer that has been returned by an earlier call to osmo_hexdump(). In short: don't mix them in a single call printf(). Sponsored-by: On-Waves ehf
* lapd: Use the right struct for the talloc_zero_array callHolger Hans Peter Freyther2014-02-091-2/+2
| | | | | | I saw this while playing with talloc pools and wondered why lapd_core is creating a log_info. Use the right struct for the array.
* sms: The msg_ref is passed from the outside so remove the wrong fixmeHolger Hans Peter Freyther2014-02-081-1/+1
|
* lapd/test: Add test case for RSL EST REQ -> LAPDJacob Erlbeck2014-01-262-15/+112
| | | | | | | | | This test case processes RSL establish requests for SMS (SAPI 3) on the SDCCH and the SACCH channels. The TX queues are checked after processing each message. Ticket: SYS#192 Sponsored-by: On-Waves ehf
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-26 21:06:30 +0000