Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add port number 4238 for BTS control interface | Harald Welte | 2014-08-24 | 2 | -0/+2 |
| | |||||
* | libctrl: Add support for 'deferred control commands' | Harald Welte | 2014-08-24 | 3 | -0/+92 |
| | | | | | | | | | | | | | | Sometimes a control interface command cannot be processed and responded immediately, but we need to process it asynchronously. In order to support this, we introduce the 'ctrl_cmd_def', which represents such a deferred command. It is created by the service implementing the command using ctrl_cmd_def_make(), and a response is later sent using ctrl_cmd_def_send(). ctrl_cmd_def_is_zombie() must be called to handle the case where the control connection has disconnected/died between receiving the command and sending the response. | ||||
* | ctrl: Attempt fix the build on FreeBSD and add include file | Holger Hans Peter Freyther | 2014-08-21 | 1 | -0/+1 |
| | | | | | IPPROTO_TCP is defined in netinet/in.h. Include it and hope the build is fixed for FreeBSD. | ||||
* | prepare for 0.7.0 release | Harald Welte | 2014-08-21 | 5 | -5/+11 |
| | |||||
* | Convert recently-introduced header files to #pragma once | Harald Welte | 2014-08-21 | 3 | -13/+3 |
| | |||||
* | New <osmocom/ctrl/ports.h> file listing tcp ports for CTRL interface | Harald Welte | 2014-08-21 | 2 | -0/+8 |
| | |||||
* | rename controlif_setup() to ctrl_interface_setup() | Harald Welte | 2014-08-21 | 2 | -4/+4 |
| | | | | | which means that all control interface related functions now have the common ctrl_ prefix. | ||||
* | libctrl: Make two internal helper functions static | Harald Welte | 2014-08-21 | 1 | -2/+2 |
| | |||||
* | libctrl: Move bulk of control node lookup inti libosmoctrl | Harald Welte | 2014-08-21 | 2 | -7/+134 |
| | | | | | | The control interface user now only has to register a very short node lookup function callback. This function is optional, and only required if hierarchical command lookup should be supported. | ||||
* | libctrl: remove 'struct gsm_network' references | Harald Welte | 2014-08-21 | 2 | -9/+6 |
| | | | | | libctrl doesn't need any knowledge about the type of the user-private data that it gets passed upon setup time and includes on callbacks. | ||||
* | libctrl: remove bsc-specific declaration | Harald Welte | 2014-08-21 | 1 | -1/+0 |
| | | | | this was moved by accident when importing the code from openbsc. | ||||
* | libctrl: adopt to recent ipaccess/ipa naming change | Harald Welte | 2014-08-21 | 1 | -2/+3 |
| | |||||
* | libctrl: autotools build system integration | Harald Welte | 2014-08-21 | 5 | -7/+27 |
| | | | | Now we actually build the recently-imported libctrl | ||||
* | libctrl: Add DLCTRL as logging context for the control interface | Harald Welte | 2014-08-21 | 4 | -29/+35 |
| | | | | ... and make libctrl code use it | ||||
* | libctrl: remove reference to bsc_replace_string() | Harald Welte | 2014-08-21 | 2 | -1/+8 |
| | | | | | ... and rather introduce a general osmo_talloc_replace_string() to libosmocore. | ||||
* | libctrl: Avoid using external tall_bsc_ctx | Harald Welte | 2014-08-21 | 1 | -6/+6 |
| | | | | | | Instead of using one flat talloc context (and one that is specific to openbsc), we should attach the objects to whatever parent context they are being used in. | ||||
* | libctrl: remove openbsc headers, convert from make_sock to libosmocore | Harald Welte | 2014-08-21 | 4 | -23/+14 |
| | |||||
* | libctrl: Remove reference to 'DNAT' in favor of 'DCTRL' | Harald Welte | 2014-08-21 | 1 | -1/+1 |
| | |||||
* | libctr: rename/move control interface to libosmocore naming scheme | Harald Welte | 2014-08-21 | 5 | -0/+0 |
| | |||||
* | ctrl: Allow the value to contain spaces. No need to split the string | Holger Hans Peter Freyther | 2014-08-21 | 1 | -1/+1 |
| | |||||
* | ctrl: Use CTRL_CMD_DEFINE_STRUCT in CTRL_CMD_DEFINE_RANGE | Holger Hans Peter Freyther | 2014-08-21 | 1 | -6/+1 |
| | | | | | Jacob pointed out that I didn't convert CTRL_CMD_DEFINE_RANGE. This patch is doing it now. | ||||
* | ctrl: Reduce code duplication and add a define to create the struct | Holger Hans Peter Freyther | 2014-08-21 | 1 | -13/+10 |
| | | | | | | This has been pointed out by Jacob and removes two more duplicates of the struct. For the unused CTRL_CMD_DEFINE_STRING macro there will be no verify command. | ||||
* | ctrl: Remove the param parameter as it was never used/implemented | Holger Hans Peter Freyther | 2014-08-21 | 2 | -6/+0 |
| | |||||
* | ctrl: Introduce a macro for read-only attributes and use it | Holger Hans Peter Freyther | 2014-08-21 | 1 | -0/+14 |
| | | | | | Certain attributes are read-only. Add a macro to make it more easy to define those. | ||||
* | ipa: Use enhanced ipa_msg_recv_buffered() to cope with partioned IPA messages | Jacob Erlbeck | 2014-08-21 | 2 | -1/+7 |
| | | | | | | | | | | | | | | The old ipa_msg_recv() implementation didn't support partial receive, so IPA connections got disconnected when this happened. This patch adds the handling of the temporary message buffers and uses ipa_msg_recv_buffered(). It has been successfully tested by jerlbeck with osmo-nitb and osmo-bsc. Ticket: OW#768 Sponsored-by: On-Waves ehf | ||||
* | ctrl: Move the lookup into a separate file in preparation for GPRS | Holger Hans Peter Freyther | 2014-08-21 | 3 | -152/+14 |
| | | | | | | For GPRS the look-up via bts/trx does not make any sense and would introduce bad depdencies for the SGSN. Move the look-up code to a new file and introduce new setup methods. | ||||
* | ctrl: Make it possible to re-use the string get and set routine | Holger Hans Peter Freyther | 2014-08-21 | 1 | -3/+7 |
| | | | | | This can be used for the description field that requires some special handling for newlines. | ||||
* | ctrl: Make the int range set, get and verify methods available | Holger Hans Peter Freyther | 2014-08-21 | 1 | -4/+12 |
| | | | | | | For the max power reduction we will need to have a different range method. It will need to check if the value is even. Make the set, get and verify methods available through a macro. | ||||
* | ctrl: Set a generic reply when it hasn'n been set | Jacob Erlbeck | 2014-08-21 | 1 | -1/+9 |
| | | | | | | | | | | | When verification failed and the reply string was not updated, the message "Someone forgot to fill in the reply." was shown instead of the default "Value failed verification." message. This patch changes the default reply handling in ctrl_cmd_handle() by setting the reply to NULL initially and then checking it at the end. If it hasn't been set, a generic message is assigned and an error is logged. | ||||
* | ctrlif: Flush/Clear write_queue when closing the control socket | Harald Welte | 2014-08-21 | 1 | -0/+1 |
| | |||||
* | Makefile.am: Use AM_CPPFLAGS | Alexander Huemer | 2014-08-21 | 1 | -1/+1 |
| | | | | Since automake 1.13 INCLUDES is depricates and causes a warning | ||||
* | ctrl: Provide a reply in case the range check failed | Holger Hans Peter Freyther | 2014-08-21 | 1 | -0/+1 |
| | |||||
* | ctrl: Make the commands static to not pollute the namespace | Holger Hans Peter Freyther | 2014-08-21 | 1 | -3/+3 |
| | | | | | We do not need to access these commands from another compilation unit and can just make it static. | ||||
* | ctrl: Work on the cmd->node instead of the data pointer passed | Holger Hans Peter Freyther | 2014-08-21 | 1 | -9/+9 |
| | | | | | | Make the macros use the cmd->node instead of the data pointer. The naming of the variable inside the macro already indicates that it should use the nodes data structure. | ||||
* | ctrl: Fix the signature of the string control commands | Holger Hans Peter Freyther | 2014-08-21 | 1 | -2/+7 |
| | | | | | | | | Like with all type unsafe callbacks we will need to cast from void to the dtype. This addresses some compiler warnings. Make it possible to only include the control_cmd.h to use the macros defined in this file. | ||||
* | libctrl, osmo-bsc: Get rid of net prefix | Daniel Willmann | 2014-08-21 | 2 | -11/+3 |
| | | | | net is now implicit in the root node | ||||
* | ctrl: Use strtol instead of atoi to detect conversion errors | Daniel Willmann | 2014-08-21 | 1 | -10/+27 |
| | |||||
* | ctrl: Improve error messages in ctrl_cmd_handle | Daniel Willmann | 2014-08-21 | 1 | -12/+28 |
| | |||||
* | ctrl: Change the paths to bts.%i. instead of bts%i | Daniel Willmann | 2014-08-21 | 1 | -6/+18 |
| | |||||
* | ctrl: Improve error handling if controlif setup fails | Daniel Willmann | 2014-08-21 | 1 | -12/+16 |
| | |||||
* | libctrl: Add function ctrl_cmd_send_to_all | Daniel Willmann | 2014-08-21 | 2 | -0/+18 |
| | | | | | Sends a command to all ctrl connections except the one it originated from. | ||||
* | libctrl: Add trap helper function | Daniel Willmann | 2014-08-21 | 2 | -0/+14 |
| | |||||
* | libctrl: Change controlif_setup so it returns the ctrl handle | Daniel Willmann | 2014-08-21 | 3 | -16/+20 |
| | | | | | | | nat: Catch up with controlif_setup API change We now save a control handle reference in the nat osmo-bsc: Catch up with controlif_setup API change We now save a control handle reference in the gsm network | ||||
* | libctrl: Keep track of connections in struct ctrl_handle | Daniel Willmann | 2014-08-21 | 1 | -1/+11 |
| | |||||
* | misc: Use other size modifiers to fix compiler warnings | Holger Hans Peter Freyther | 2014-08-21 | 1 | -1/+1 |
| | | | | | | control_if.c:521:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Wformat] osmo_bsc_bssap.c:473:3: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Wformat] mgcp_main.c:162:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformatt] | ||||
* | libctrl: only free() msgb if it was alloc()ed | Alexander Huemer | 2014-08-21 | 1 | -1/+1 |
| | | | | | | Before this patch a SIGABRT was caused when doing e.g.: $ ncat 127.0.0.1 4249 ^C | ||||
* | fix some "implicit declaration" warnings in osmo-nitb | Alexander Huemer | 2014-08-21 | 1 | -0/+13 |
| | |||||
* | libctrl: Add a function to create the cmd | Holger Hans Peter Freyther | 2014-08-21 | 2 | -0/+13 |
| | |||||
* | libctrl: Don't overwrite error reply if the verify function sets one | Daniel Willmann | 2014-08-21 | 1 | -1/+3 |
| | |||||
* | libctrl: Mark the cmd set/get/verify functions static | Daniel Willmann | 2014-08-21 | 2 | -14/+14 |
| |