summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add LAPDm collision test (contention resolution on network side)Andreas Eversberg2013-07-061-0/+69
|
* get_value_string: Null terminate after the call to snprintfHolger Hans Peter Freyther2013-07-041-0/+1
| | | | | | | It is impossible that the snprintf will fill the entire namebuf but just follow the idiom to make sure it is null terminated. Related: Coverity CID 1040676
* vty: Attempt to fix various meam leaks in the VTY lookup codeHolger Hans Peter Freyther2013-07-031-0/+3
| | | | | | | | | | These routines were not freeing vectors used for the lookup. On review it is fixing another path not detected by coverity. The danger is a double free in tab completion now. It is difficult to test this. Fixes: Coverity CID 23037, CID 23038
* gsm0408: Avoid unaligned memory access in gsm48_generate_mid_from_tmsiHolger Hans Peter Freyther2013-07-033-2/+26
| | | | | | | | The &buf[3] is unlikely to be aligned properly. Use memcpy instead of an assignment. Add a small testcase that verifies that I didn't mess up the conversion. Alignment trap: osmo-nitb (3293) PC=0x492b7094 Instr=0xe5803003 Address=0xbeb259db FSR 0x801
* strrb: Remove a tautology from the codeHolger Hans Peter Freyther2013-07-031-1/+1
| | | | | | | | This already came up during review but now that Coverity complains about it as well, let us just remove it. The variable is unsigned so it can never be < 0. Fixes: Coverity CID 1040669.
* misc: Fix compiler warnings about the static_assert macro with gcc 4.8Holger Hans Peter Freyther2013-07-011-1/+1
| | | | | | | | | | | | | The modified macro is still working on a gcc 4.7 and gcc 4.8 after the removal of the typedef and addition of the unused attribute. include/osmocom/core/msgb.h: In function ‘msgb_alloc_headroom’: include/osmocom/core/utils.h:40:51: warning: typedef ‘dummyheadroom_bigger’ locally defined but not used [-Wunused-local-typedefs] #define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1]; ^ include/osmocom/core/msgb.h:386:2: note: in expansion of macro ‘osmo_static_assert’ osmo_static_assert(size > headroom, headroom_bigger); ^
* debian: Prepare the 0.6.2 release with a new changelogHolger Hans Peter Freyther2013-07-011-2/+2
|
* BSSGP: prevent divide-by-zero in flow controlHarald Welte2013-06-291-10/+33
| | | | | | | If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
* introduce gsm0808_create_reset_ack()Harald Welte2013-06-292-0/+14
|
* fr: Fix the linking of the test and use $(LIBRARY_DL) for linkingHolger Hans Peter Freyther2013-06-261-1/+1
| | | | | | | | On Ubuntu 13.04 the build was failing on the OBS with: /usr/bin/ld: fr_test.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5' /usr/bin/ld: note: 'dlsym@@GLIBC_2.2.5' is defined in DSO /lib/x86_64-linux-gnu/libdl.so.2 so try adding it to the linker command line /lib/x86_64-linux-gnu/libdl.so.2: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status
* lapd: Upate the assert to OSMO_ASSERT and describe what we would like to haveHolger Hans Peter Freyther2013-06-191-2/+2
| | | | | Update the OSMO_ASSERT to what it should be like but can't due a known issue in the LAPDm code.
* lapd: The two known LAPDm issues have been addressed, update the testHolger Hans Peter Freyther2013-06-192-13/+7
| | | | | | | | | The issue about the wrong padding has been found when creating the testcase in commit 15f740caa3a1ef681b3a5564daf6dfccb7b1e489 but the patch to fix that was never proposed by inclusion by its author. The issue about about the establish confirm carrying data with a wrong size is still present.
* lapd_core: msgb_trim() the L2 padding from ESTABLISH.indHarald Welte2013-06-181-2/+3
| | | | | | | | When a SABM(E) frame arrives, we have to trim the L2 padding (0x2b for gsm) before handing the data off to L3, just like we do with I frames. Also, we should use mggb_trim() or even msgb_l3trim() instead of manually fiddling with msgb->length and ->tail pointers.
* Makefile.am: Use AM_CPPFLAGSAlexander Huemer2013-06-121-1/+1
| | | | Since automake 1.13 INCLUDES is depricates and causes a warning
* misc: Fix the spelling of frame in the RLM cause stringsHolger Hans Peter Freyther2013-06-111-1/+1
|
* gsm_04_08.h: GSM48_MT_RR_VGCS_UPL_GRANT value correctedBhaskar2013-05-231-1/+1
|
* gsm_04_08.h: Fix GSM48_CMODE_DATA_3k6 as per 3GPP TS 04.08 / 10.5.2.6.Bhaskar2013-05-231-1/+1
|
* gsm_utils: refer to ETSI TS 05.08 instead of TS 08.05Bhaskar2013-05-232-3/+3
|
* lapd: Set the tx_hist to NULL after freeing itHolger Hans Peter Freyther2013-05-081-0/+1
| | | | | Make detecting use after free of the tx_hist easy and set the variable to NULL after talloc_free has been freed.
* osmo-arfcn: Return something from the methodHolger Hans Peter Freyther2013-04-211-0/+1
| | | | This is a fatal error when building RPMs for OpenSUSE.
* Merge branch 'zecke/jolly-lapdm-fixes'Holger Hans Peter Freyther2013-04-074-6/+104
|\ | | | | | | * Squashed fix and testcase into one.
| * Fix of potential memory leaks at lapdm.cAndreas Eversberg2013-04-061-4/+17
| |
| * Fix: LAPDm contention resoltion must acknowledge subsequent SABMAndreas Eversberg2013-04-063-2/+87
|/ | | | | | | | | After reception of SABM, the network responds with UA and enters the establised multiframe state. If UA is not received by mobile, the SABM is transmitted again, and the network must respond with UA again, unless it is from a different mobile. Add LAPDm collision test (contention resolution on network side).
* debian: Start a new release cycle with libosmocore 0.6.0Holger Hans Peter Freyther2013-03-251-1/+7
|
* gprs_ns: Allow to set the DSCP for the UDP socket.Holger Hans Peter Freyther2013-03-254-0/+25
| | | | Allow to tag the NS service with a custom DSCP.
* tests: Verify that all tests exit with status=0.Holger Hans Peter Freyther2013-03-251-17/+17
|
* utils: Use fprintf to print the assertion and generate a backtraceKaterina Barone-Adesi2013-03-251-1/+2
| | | | | | | | | This is changing the semantic of the assert. The regression tests now either need to check the stderr result, the exit status or print a message when all tests are completed. This is not that bad as the osmo_generate_backtrace is printing to the stdout right now.
* logging_vty: Fix segfault un unused entries in log_info_cat array of appHarald Welte2013-03-191-0/+4
|
* Revert "Follow up fix for the log level "everything""Harald Welte2013-03-191-3/+0
| | | | This reverts commit a6428d2376034d619f342897d3ce415b3f9a3584.
* Revert "Fix log level "everything" and make it equal to "debug""Harald Welte2013-03-191-1/+1
| | | | This reverts commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5.
* application: don't ignore SIGHUP but do config file reopen.Harald Welte2013-03-181-1/+6
|
* logging: add new log_targets_reopen() functionHarald Welte2013-03-182-0/+21
| | | | | This function will re-open all existing log files in the application, praticularly useful for SIGHUP handlers in case of logrotate
* add new gsm/meas_rep.h file for shared/common measurement report stuffHarald Welte2013-03-132-0/+30
|
* Add smpp34_osmocom.h for Osmocom SMPP vendor additionsHarald Welte2013-03-132-0/+49
|
* gsm_septets2octets(): Input parameter should be constHarald Welte2013-03-132-2/+3
|
* logging_vty: Print 'log filter all' info in 'show logging vty'Harald Welte2013-03-131-0/+6
| | | | | When we print information about the current logging configuration, it makes sense to also print information about the log filters.
* utils: Introduce OSMO_ASSERT in the utils and use it in the unit testsKaterina Barone-Adesi2013-03-094-98/+100
| | | | | The tests should unconditionally assert, regardless of debug settings. This uses the OSMO_ prefix as it's in the global namespace.
* cygwin: Link many libraries with -no-undefined to create a dllHolger Hans Peter Freyther2013-03-034-5/+5
| | | | | | Only the Gb library relies on having undefined references to a symbol that needs to be provided by the host application. For all other libraries we can link with -no-undefined.
* codec: Fix the GSM 06.20 ordering tablesSylvain Munaut2013-03-011-41/+41
| | | | | | | | | | Seems the script I used to parse those had a bug where range of bits in the 'decreasing' direction ( like 6..0 ) were not processed properly. Thanks to Andreas for noticing this ! Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* Follow up fix for the log level "everything"Holger Hans Peter Freyther2013-02-271-0/+3
| | | | | | | | | | | | Commit cd6ed82d1ff48f47ad9e33e6322df62896a76ed5 made "EVERYTHING" map to LOGL_DEBUG but when writing out the configuration the following would be written: logging level all unknown 0x0 This happend because no string was found for the value 0. Address it by adding a legacy check for 0 and write out the str from the index 0. Currently this is "EVERYTHING".
* Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi2013-02-2716-8/+796
| | | | | | | The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
* Revert "Added a ring buffer log target to store the last N log messages."Holger Hans Peter Freyther2013-02-2715-792/+8
| | | | | | | I noticed some more issues and it is the easiest to revert and include the fixed version. This reverts commit 73377229bb33ab79682ce4b126a63602d13304ad.
* Added a ring buffer log target to store the last N log messages.Katerina Barone-Adesi2013-02-2715-8/+792
| | | | | | | The log target can be used via log alarms and show alarms. Why? This feature was proposed/requested at http://openbsc.osmocom.org/trac/wiki/Tasks/ErrorLogTarget All messages use the same amount of space, prioritizing simplicity.
* Add UMTS RRC message typesTobias Engel2013-02-211-0/+68
|
* Fix log level "everything" and make it equal to "debug"Harald Welte2013-02-191-1/+1
| | | | | | As Holger points out "logging level XXX everything" wasn't working, as it sets category->loglevel to 0, which is checked in osmo_vlogp() and will never get logged.
* misc: Doxygen tweaks: fixed some typos and minor errorsKaterina Barone-Adesi2013-02-1526-38/+45
| | | | | Doxygen generates quite a lot of warnings on libosmocore. Some of them are obvious typos - this patch aims to fix such low-hanging fruit.
* debian: Re-enable the debug packagesHolger Hans Peter Freyther2013-02-135-13/+11
| | | | | | Remove the .dirs/.install as things will go wrong then. debhelper will try to install the debug symbols before they were created. Thanks to Jan for pointing that out.
* debian: Update the change log for a new packageHolger Hans Peter Freyther2013-02-131-2/+3
|
* VTY: don't show HIDDEN or DEPRECATED vty commands in ? completionHarald Welte2013-02-121-0/+3
| | | | | | | This hides HIDDEN or DEPRECATED commands from showing up when the full list of commands is inquired with '?' at any given point in the command tree. Only if the hidden/deprecated command is already typed in partially, then it will still tab-complete.
* vty/command.c: Cosmetic cleanupHarald Welte2013-02-121-82/+81
| | | | | this is just changing some of the code to reduce the way too high level of indentation and thus improve readability.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 10:16:55 +0000