summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* vty/command.c: Cosmetic cleanupHarald Welte2013-02-121-82/+81
| | | | | this is just changing some of the code to reduce the way too high level of indentation and thus improve readability.
* abis_nm: add parenthesis for new abis_nm_debugp_foh() macroHarald Welte2013-02-101-3/+3
| | | | without this, we break e.g. the openbsc build...
* turn abis_nm_debugp_foh() into a macroHarald Welte2013-02-102-13/+21
| | | | | | this will avoid printing 'abis_nm.c' as the filename in the log, which is pretty useless during debugging. We want to know where abis_nm_debugp_foh() is being used from, not where it is implemented.
* doc: Fix typo in Doxyfile.core.in causing sources to be ignoredSylvain Munaut2013-02-081-1/+1
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* core/crc: Fix the 64 bits implementationSylvain Munaut2013-02-011-2/+2
| | | | | | | We used 1ULL at one place and not the other ... at the same time, we now use (uintXX_t) so that the proper type is used each time. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* fr_test: Speculative build fix for FreeBSDHolger Hans Peter Freyther2013-01-151-0/+3
|
* fr: Begin with a GRE/FrameRelay test due the recent regressionHolger Hans Peter Freyther2013-01-156-2/+93
| | | | | | | | | | | The framerelay code is seldomly used and the socket clean ups introduced a regression. Create a testcase that will work as a user not having the right capabilities to create raw sockets. We have to make sure that this test is working even when not ran as root. The easiest way to do this is to provide our own socket implementation. This is done with dlopen/dlsym to convert the raw socket request to an UDP one.
* socket: fix osmo_sock_init with SOCK_RAW and IPPROTO_RAWPablo Neira Ayuso2013-01-151-3/+16
| | | | | | | | | | | | | getaddrinfo returns EAI_SERVICE (-8) if that combination is used. More information available in here: http://sourceware.org/bugzilla/show_bug.cgi?id=15015 Reported by Holger Hans Peter Freyther. While at it, this patch also removes hints.ai_flags = 0 as memset to zero already happened just a bit before that.
* Fix build on CygwinEvgeny Zverev2013-01-121-1/+5
|
* add some missing doxygen annotation for libosmocore functionsHarald Welte2013-01-117-11/+75
|
* doxyfiles: refer paths to @srcdir@Alex Badea2013-01-064-4/+4
| | | | | | | | When building out-of-srcdir, paths such as "src/gsm" will not find any source files. Since the Doxyfiles are preprocessed, we can prepend @srcdir@ to fix that. Signed-off-by: Alex Badea <vamposdecampos@gmail.com>
* tests/timer: tweak path to config.hAlex Badea2013-01-061-1/+1
| | | | | | | | | When building out-of-srcdir, "../../config.h" fails to reach config.h because the compiler is invoked in $builddir/tests/, not $builddir/tests/timer/. Use "../config.h" instead; this also works for in-srcdir builds. Signed-off-by: Alex Badea <vamposdecampos@gmail.com>
* Replace obsolete automake AM_CONFIG_HEADER.Christian Vogel2013-01-061-1/+1
| | | | | | | | | | | | | | This fixes the following complaint by autoconf 2.69-1, automake 1.13.1-1. : configure.ac:80: error: 'AM_CONFIG_HEADER': this macro is obsolete. : You should use the 'AC_CONFIG_HEADERS' macro instead. : /usr/share/aclocal-1.13/obsolete-err.m4:12: AM_CONFIG_HEADER is expan : configure.ac:80: the top level Automake 1:1.11.3-1ubuntu2, autoconf 2.68-1ubuntu2 don't even emit a warning without, and work just fine with this patch. Signed-off-by: Christian Vogel <vogelchr@vogel.cx>
* debian: Bump the changelog and package osmo-arfcnHolger Hans Peter Freyther2013-01-044-0/+16
|
* vty: Do better filtering of arguments, optional args particularlySylvain Munaut2013-01-031-208/+143
| | | | | | | | This is essentially http://patchwork.diac24.net/patch/271/ forward ported to libosmovty Original-by: Paul Jakma <paul@quagga.net> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* core/bits: Prevent osmo_revbytebits_buf stack trashingSylvain Munaut2013-01-031-1/+1
| | | | | | | | | | | | The second loop in osmo_revbytebits_buf() in src/bits.c grabs 4 bytes each iteration, which can easily go past the supplied input in some cases. Compiled with -fstack-protector , I get a "stack smashing detected" in the bits test. From: Nils O. Selåsdal <noselasd@fiane.dyndns.org> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* tests: Don't delete atconfig in cleanDaniel Willmann2012-12-261-1/+2
| | | | | | | | This file is created in ./configure so we shouldn't remove it with make. Otherwise ./configure && make clean && make check fails with: make[3]: *** No rule to make target `atconfig', needed by `check-local'. Stop.
* lapd: Fix compiler warnings in the lapd codeHolger Hans Peter Freyther2012-12-261-0/+2
| | | | | | | | lapd_test.c: In function ‘ms_to_bts_l1_cb’: lapd_test.c:192:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] lapd_test.c:199:1: warning: no return statement in function returning non-void [-Wreturn-type] lapd_test.c: In function ‘main’: lapd_test.c:355:2: warning: implicit declaration of function ‘osmo_init_logging’ [-Wimplicit-function-declaration]
* lapd: Check in rslms_rx_rll() if lapdm context was initialized earlierDaniel Willmann2012-12-263-2/+62
| | | | | | | | | | | | | | | | | | This was found while implementing handover on a sysmobts. When we receive a channel release request for a channel that was never really activated (set_lapdm_context() was not called) we segfault in lapd_recv_dlsap(). We now return early with -EINVAL in rslms_rx_rll() if we receive a message that assumes set_lapdm_context() was already called. These are: * RSL_MT_UNIT_DATA_REQ * RSL_MT_DATA_REQ * RSL_MT_SUSP_REQ * RSL_MT_REL_REQ A test case was added to trigger the issue.
* Add tlvp_val16_unal() / tlvp_val32_unal() to align 16 and 32 bit valuesAndreas Eversberg2012-12-181-0/+24
| | | | | This is required for CPUs < armv6, to access 16 and 32 values at right memory locations.
* core: Fix missing include in msgfile.c for getlineSylvain Munaut2012-12-121-0/+1
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* build: Don't use the deprecated INCLUDES in the various Makefile.amSylvain Munaut2012-12-117-12/+8
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* utils/osmo-arfcn: Implement option to get ARFCN from frequencySylvain Munaut2012-12-111-1/+32
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* gsm: Add method to find ARFCN based on frequencySylvain Munaut2012-12-113-45/+69
| | | | Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* osmo-arfcn: add support for PCS bandHarald Welte2012-12-061-6/+13
|
* rsl: Add the 9.3.20 release mode enum to be used in OpenBSCHolger Hans Peter Freyther2012-12-061-0/+6
|
* sms: Print 'network' or 'mobile' when creating the SMC/SMRHolger Hans Peter Freyther2012-12-062-3/+4
|
* gsm/a5: Return -ENOTSUP if the selected cipher is not supportedSylvain Munaut2012-12-062-3/+7
| | | | | | Extracted from a patch by Max Suraev Max.Suraev@fairwaves.ru> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
* lapd: Use LOGL_ERROR for messgaes that are wrong in the given contextHolger Hans Peter Freyther2012-11-261-14/+14
| | | | Log message that are either too big or have the C/R bit set as error.
* misc: Use static const struct for LAPD and AbisHolger Hans Peter Freyther2012-11-222-2/+2
|
* sms: Mark the state dispatch table as static constHolger Hans Peter Freyther2012-11-222-4/+4
| | | | | | GCC 4.7.2 was already smart enough to see that the table is const so there is no change in the generated assembly code. For some reason the dispatch is still going through one relocation.
* sms: Fix typos in the comments and log messages.Holger Hans Peter Freyther2012-11-222-5/+5
|
* smr: Introduce an id and prefix all log messages with SMR(ID)Holger Hans Peter Freyther2012-11-222-32/+70
| | | | | | | | | | When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMR instance. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMR(ID). This change is ABI and API incompatible with previous versions of libosmogsm.
* smc: Introduce an id and prefix all log messages with SMC(ID)Holger Hans Peter Freyther2012-11-222-31/+62
| | | | | | | | | | | | | | When OpenBSC is handling more than one message at a time it is difficult to see which log message belongs to which SMC. Introduce a uint64_t id that can be set to the row_id/message_id and prefix all log messages with SMC(ID). This change is ABI and API incompatible with previous versions of libosmogsm. Example: SMC(100) instance created SMC(100) message MNSMS-EST-REQ received in state IDLE
* actually install osmo-arfcn and osmo-auc-gen as part of 'make install'Harald Welte2012-11-161-1/+1
|
* msgb: fix msgb_pull_u*()Steve Markgraf2012-11-141-3/+3
| | | | | | | | msgb_pull returns a pointer to the new begin of the buffer, unlike msgb_get(), where those functions were originally taken from. Signed-off-by: Steve Markgraf <steve@steve-m.de>
* smc: Fix a typo in the smc codeHolger Hans Peter Freyther2012-11-141-1/+1
|
* smc: Make it possible to include gsm0411_smc.h as first header fileHolger Hans Peter Freyther2012-11-141-0/+1
| | | | The code embeds the timer so one needs to include the header file.
* smc: Print the current state of the SMSHolger Hans Peter Freyther2012-11-111-1/+3
| | | | | | When the connection may not released print the name of the current state to ease with debugging and verification that this is not a valid state transition.
* sms: Remove the commented out code that was the default in OpenBSCHolger Hans Peter Freyther2012-11-111-1/+0
| | | | | This code got copied from OpenBSC and we used the network specific and private numbering plan. Remove it as it can be easily set.
* sms: Reduce the logging level to debugHolger Hans Peter Freyther2012-11-111-3/+3
| | | | | <001c> gsm0411_smr.c:175 TX: MNSMS-REL-REQ adds little value so I am reducing it to a debug statement.
* debian: Create a git-buildpackage based 0.5.3Holger Hans Peter Freyther2012-11-062-1/+7
|
* debian: Testing was disabled because of a funny x86 compiler issue caused by usHolger Hans Peter Freyther2012-11-051-5/+0
| | | | | | | | The bits test will fail on Debian Stable for x86. Somehow the load of a static const array is ending up accessing random memory. This only happens when not using any -OX options and this is caused by us. Do not override the default debian CFLAGS.. and the tests will pass on debian stable.
* GSM48: Avoid unaligned access in gsm48_construct_raAndreas Eversberg2012-11-051-1/+3
| | | | | This avoids an unaligned access on platforms that don't support them, such as ARMv4/ARMv5.
* Add "extern" keywordsTobias Engel2012-10-271-5/+5
| | | | | Without the "extern" keyword the variables in this header file will be seen as empty definitions when compiled on OSX.
* Do not use --version-script linker flag on OSXTobias Engel2012-10-273-2/+14
| | | | | Add a check to not use --version-script linker flag if compiled on OSX since it doesn't exist there
* Define struct iphdr for OSXTobias Engel2012-10-271-1/+1
| | | | | | | | | | Use FreeBSD struct iphdr definition for OSX also. From the commentary in the source file: On BSD the IPv4 struct is called struct ip and instead of iXX the members are called ip_XX. One could change this code to use struct ip but that would require to define _BSD_SOURCE and that might have other complications. Instead make sure struct iphdr is present on FreeBSD.
* logging: Make sure to install standard "end" command in VTY nodeHarald Welte2012-10-222-0/+3
| | | | | When you are in the config-log VTY node, you expect "end" to work like in any other sub-node of config.
* logging: Don't forget to save "logging filter all 1"Harald Welte2012-10-221-0/+4
| | | | | | | Prior to this fix, a persistent file or syslog log configuration didn't work across an application re-start, as the "logging filter all 1" was never saved and thus no messages were logged.
* Doc: Adding new parameter descriptions in gprs_bssgp_bss.cAndreas Eversberg2012-09-301-1/+9
|