summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* vty: Make vty_event dispatch signals and use it in the testcaseHolger Hans Peter Freyther2013-10-104-5/+45
| | | | | | | | | The testcase didn't work on Ubuntu 12.04 because vty_create will directly call vty_event (e.g. not through the plt). This means that the approach to override vty_event in the testcase failed. Use the signal interface of libosmocore and make the testcase use it. The signals can be generally useful as well.
* debian: Print test results in case of a failureHolger Hans Peter Freyther2013-10-101-0/+4
|
* gb: Use the NS-VCI to find an existing NS-VCJacob Erlbeck2013-10-082-7/+8
| | | | | | | | | | | | | | | | Currently when a NS-RESET is recevied over a link that has not yet been associated with a NS-VC, the NSEI is used to find an existing NS-VC. If one is found, the reset procedure is initiated. This behaviour is not conformant with 3GPP TS 08.16 (see chapter 4.2.3) which allows to use several NS-VC between two endpoints in parallel. The patch changes the implementation to use the NSVCI instead of the NSEI to search for an existing NS-VC object. Ticket: OW#874 Sponsored-by: On-Waves ehf
* gb: Fix NS-RESET response message orderJacob Erlbeck2013-10-082-23/+25
| | | | | | | | | | | | | | According to 3GPP TS 08.16, 7.3 "Reset procedure" the entity receiving a NS-RESET PDU responds with a NS-RESET-ACK and 'then' starts the test procedure which essentially means, that a NS-ALIVE gets sent and a timer is started. Currently the NS-ALIVE is sent before the NS-RESET-ACK. This patch fixes the implementation by reversing the order in which these messages are sent. Sponsored-by: On-Waves ehf
* gb: Separate nsvc creation from NS message processingJacob Erlbeck2013-10-082-55/+153
| | | | | | | | | | | | This patch refactors gprs_ns_rcvmsg() by moving the parts relevant to the NS messages into the new functions gprs_ns_vc_create() (nsvc object creation) and gprs_ns_process_msg() (main NS automaton). These do not contain code that directly depends on the link layer (they call other functions that still do). This reduces the gprs_ns_rcvmsg() function to calling these two functions and optionally setting up the link layer specific fields of the nsvc. Sponsored-by: On-Waves ehf
* tests/gb: Add test for GPRS NS protocolJacob Erlbeck2013-10-084-1/+383
| | | | | | This tests the connection establishment by directly calling gprs_ns_rcvmsg() and printing the resulting messages and the NS-VC list.
* tests: Fix warningsJacob Erlbeck2013-10-085-5/+8
| | | | | | This fixes warnings that are raised by missing includes, missing casts, missing return statements, using printf %lu with uint64_t, and unused symbols.
* msgb: Add may_alias attribute to struct libgb_msgb_cbJacob Erlbeck2013-10-081-1/+1
| | | | | | | | | | This explicitely allows aliasing of this struct to avoid the warning shown below. Note, that this warning isn't show when '-fno-strict-aliasing' is used. Addresses: gb/gprs_ns_test.c:85:54: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
* tests: Fix the sms_test and use the right arrayHolger Hans Peter Freyther2013-10-081-1/+1
| | | | | | It started to behave weird on Debian Testing (GCC 4.8), I compiled it with address sanitizer support and set a breakpoint in __asan_report_error to get a backtrace.
* bssgp: Address various compiler warnings in the bssgp codeHolger Hans Peter Freyther2013-09-161-0/+3
| | | | | | | | | gb/bssgp_fc_test.c: In function ‘fc_out_cb’: gb/bssgp_fc_test.c:46:1: warning: no return statement in function returning non-void [-Wreturn-type] gb/bssgp_fc_test.c: In function ‘fc_in’: gb/bssgp_fc_test.c:56:1: warning: no return statement in function returning non-void [-Wreturn-type] gb/bssgp_fc_test.c: In function ‘test_fc’: gb/bssgp_fc_test.c:79:3: warning: implicit declaration of function ‘usleep’ [-Wimplicit-function-declaration]
* gsm48: Added 'Network Daylight Saving Time' info elementJacob Erlbeck2013-09-162-0/+2
| | | | | | | | This information element has been added to the MM Information message in GSM24.008. This patch adds it to the tlv_definition to keep the TLV parser from breaking. Ticket: OW#978
* vty: Allow vty_go_parent() in all nodes.Jacob Erlbeck2013-09-111-5/+25
| | | | | | | This patch removes an assertion of node > CONFIG_NODE and changes the function to handle all nodes properly. For the sake of completeness, the generic 'exit' command implementation is extended to work properly with all nodes, too.
* vty: Fix compiler warning in the testHolger Hans Peter Freyther2013-09-101-1/+2
|
* vty: Replace 'enum node_type' by 'int' for last_nodeJacob Erlbeck2013-09-101-1/+1
| | | | | In this case the last_node variable may hold values that are not in enum node_type, so int is used instead.
* vty: Add vty_install_default() and use for the vty nodesJacob Erlbeck2013-09-086-7/+188
| | | | | | | | | | | This adds the vty_install_default() function that is basically the install_default() function plus the registration of the commands 'exit' and 'end'. The latter is only provided in subnodes of ENABLED_NODE and CONFIG_NONE. The VTY test program is extended to check these commands. Ticket: OW#952
* vty: Refactored vty_go_parent(), 'end' and 'exit'Jacob Erlbeck2013-09-081-22/+35
| | | | | | Put all 'exit' logic into vty_go_parent() and replace the implementations of 'exit' and 'end' by generic ones that use vty_go_parent().
* vty: Rename is_config() to is_config_child()Jacob Erlbeck2013-09-081-3/+3
| | | | | The function is_config() returns 0 for CONFIG_NODE. Since that node is a config node, the function is renamed to resolve this.
* misc: Include time.h for time_t on FreeBSDHolger Hans Peter Freyther2013-09-041-0/+2
| | | | | Fix the build after I changed the order of header files in the SMS test.
* Merge branch 'zecke/features/alpha-numeric'Holger Hans Peter Freyther2013-09-045-10/+103
|\
| * sms: Implement encoding the address as alphanumeric typeHolger Hans Peter Freyther2013-09-045-10/+103
|/ | | | | | The number of digits is the number of used octets times two (two digits per octet). The result has been successfully dissected by wireshark. It has not been tested with real phones.
* core: Remove defined() check for OSMO_DEPRECATEJacob Erlbeck2013-08-151-11/+5
| | | | | | | | This reverts commit bf991bc0f3006eddf45d494ee7e476a75dbaf36e and fixes the bug instead. It's just sufficient to remove the defined() test, since identifiers that aren't macros are just considered as 0 when used with #if. (see cpp info page, section 4.2.2 'If' in cpp-4.6.info)
* core: Fix-up the OSMO_DEPRECATED for older compilersHolger Hans Peter Freyther2013-08-141-3/+9
| | | | | | | The code started to use #if defined(...) but the value was always for GCC/Clang. The only difference was that for older compilers the value of the definition was 0. Conditionally define these macros.
* core: Support clang with OSME_DEPRECATEDJacob Erlbeck2013-08-141-4/+15
| | | | | Separate feature checking from implementation. Supported are clang and gcc.
* conv: Fix main() of conv_test to compile with clang.Jacob Erlbeck2013-08-141-1/+2
| | | | | | | | | | Fix type of argument 'argv'. Addresses: conv/conv_test.c:358:5: error: second parameter of 'main' (argument array) must be of type 'char **' int main(int argc, char argv[])
* core: Move OSMO_DEPRECATED to new core/defs.h fileJacob Erlbeck2013-08-143-13/+41
| | | | | | | | | | Add a new core/defs.h file for definitions that can be used from within header files without including prototypes and extern declarations. It's primarily meant for macro definitions and basic typedefs. Move the definition of OSMO_DEPRECATED there and use compiler version info to avoid compiler errors.
* tests: Move expensive tests to the end of the listJacob Erlbeck2013-08-131-13/+13
| | | | | This lets make check fail earlier (in average) to shorten the debugging cycle time.
* sms: Disable deprecated messageJacob Erlbeck2013-08-121-6/+20
| | | | | This is a workaround to make the FreeBSD8.4 and Debian6.0 target build again. The deprecated attribute doesn't have arguments.
* sms: Added comment about the gsm_7bit_alphabet tableJacob Erlbeck2013-08-121-2/+6
| | | | | The table structure is not intuitive, so this comment shall aid to understand this.
* sms: Added result buffer size parameter to 7bit conv funsJacob Erlbeck2013-08-128-127/+290
| | | | | | | | | | | | | The 7bit<->8bit encoding/decoding functions didn't check whether there is still enough space in the destination buffer. Therefore a buffer size parameter has been added to each of the functions which is used to truncate the output if the buffer is too small. In addition, the return value of the decoding functions has been changed to number of characters written (excluding \0), so this value is always equal to strlen(decoded). The old functions are still available as wrapper functions.
* debian: Split libosmocore into various libs and address lintian warningsHolger Hans Peter Freyther2013-08-1211-10/+49
| | | | | | | | | | | | | | | Package the various libraries separately. This will allow to install libosmogsm3 and libosmogsm4 in parallel. E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmocore.la E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmogb.la E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmogsm.la E: libosmocore-dev: non-empty-dependency_libs-in-la-file usr/lib/libosmovty.la W: libosmocore-dbg: wrong-bug-number-in-closes l54:#nnnn W: libosmocore: wrong-bug-number-in-closes l54:#nnnn W: libosmocore: package-name-doesnt-match-sonames libosmocodec0 libosmocore4 libosmogb2 libosmogsm4 libosmovty0
* lapd: Remove the double NULL check idiom with msgb_freeHolger Hans Peter Freyther2013-08-091-22/+13
| | | | | | | | | | | | | | if (ptr) msgb_free(ptr) extends to: if (ptr) talloc_free(ptr) And according to the talloc documentation a talloc_free(NULL) will not crash: "... Likewise, if "ptr" is NULL, then the function will make no modifications and returns -1."
* debian: Create a new upstream changelog entryHolger Hans Peter Freyther2013-08-091-0/+6
|
* gsm: The LAPDm prim/structs changed, increment current versionHolger Hans Peter Freyther2013-08-091-1/+1
|
* ussd: Changed 7bit test to check spec conformance directlyJacob Erlbeck2013-08-081-6/+13
| | | | | | | | | | | Renamed gsm_7bit_ussd() to test_7bit_ussd() and extended the function to take the expected binary encoding and eventually added trailing bytes in the re-decoded text as arguments. These are used to check assertions of the right behaviour instead of solely relying on regression data, because the value are determined by the spec and fixed and it is more obvious this way. Especially concerning the case with the duplicated \r which can easily be overlooked when it's only present in the ok file.
* Add special 7-bit encoding and decoding functions for USSD codingAndreas Eversberg2013-08-086-5/+83
| | | | | | | | | | | | | | | | | | | | | | | | Handling 7-bit coding is a little different for USSD, as TS 03.38 states: To avoid the situation where the receiving entity confuses 7 binary zero pad bits as the @ character, the carriage return or <CR> character shall be used for padding in this situation [...]. If <CR> is intended to be the last character and the message (including the wanted <CR>) ends on an octet boundary, then another <CR> must be added together with a padding bit 0. The receiving entity will perform the carriage return function twice, but this will not result in misoperation as the definition of <CR> [...] is identical to the definition of <CR><CR>. The receiving entity shall remove the final <CR> character where the message ends on an octet boundary with <CR> as the last character. Jacob has verified the fix with fakeBTS and the wireshark dissector. Fixes: OW#947 Reviewed-by: Jacob Erlbeck <jerlbeck@sysmocom.de>
* encoding: Provide an overload for the gsm_7bit_encode and a simple testHolger Hans Peter Freyther2013-08-085-2/+28
| | | | | | | This is required for encoding the SMS header using the alpha numeric rules. Reviewed-by: Jacob Erlbeck <jerlbeck@sysmocom.de>
* gsm: Try to clarify why we have gsm_septet_encode in the header fileHolger Hans Peter Freyther2013-08-071-0/+1
| | | | | These functions are not meant to be used by applications and are only here for the unit tests. Try to document that.
* vty: Support multi-char separators and end stringsJacob Erlbeck2013-08-062-5/+6
| | | | | In vty_cmd_string_from_valstr() include the real string lengths of the sep and end arguments into the buffer size calculation.
* vty: Fix misusage of snprintf in vty/utils.cJacob Erlbeck2013-08-066-4/+71
| | | | | | | | | | | | | | | Compiled with ubuntu 1204 (precise), where -Wformat-security is enabled by -Wall. Test yields ok, but the current implementation doesn't properly support multi-character separators and end strings. So the test output is truncated. Addresses: utils.c: In function 'vty_cmd_string_from_valstr': utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:84:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security] utils.c:108:2: warning: format not a string literal and no format arguments [-Wformat-security]
* utils: Fix compiler warnings n the osmo-auc-gen utilityHolger Hans Peter Freyther2013-07-141-1/+3
| | | | | | | osmo-auc-gen.c:217:3: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration] osmo-auc-gen.c:249:3: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t’ [-Wformat] Fixes: Coverity CID 1040668
* vty: Fix logically dead code in the description handlingHolger Hans Peter Freyther2013-07-141-1/+1
| | | | | | | | | | The code most likely wanted to check the result of argv_concat. To do this we need to dereference the dptr. Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement "return 1; Fixes: Coverity CID 1040675
* gsm0808.c: Add TLV definition for LAYER3_HEADER_INFORMATIONDmitri Soloviev2013-07-111-0/+1
| | | | | This is required for osmo-bsc to parse Alcatel S-12 CIPHER MODE COMMAND in osmo-bsc.
* LAPD: Free resume/re-establishment msgb if it carries no contentAndreas Eversberg2013-07-101-2/+5
| | | | | | | | | lapdm.c takes the re-establishment message and forwards it to lapd_core.c, so we can assume that msgb is set at primitive. In case there is data in the re-establishment msg, it is moved into send_buffer. In case of no data (0 length), it must be freed. Fixes an issue spotted by Coverity Scan.
* gsm: Revert the gsm_7bit_encode changes as they are wrongHolger Hans Peter Freyther2013-07-072-30/+9
| | | | | | | | | | | | | | | This reverts commit f996b05dbddccb8e8788dd69777a4fedfa2373eb and 2b0cac4ef83137ee0bdd583aee877eac467abeab. A detailed explanation can be found here: http://lists.osmocom.org/pipermail/openbsc/2013-July/004737.html The short description is that: 1.) The API should return (as out parameter) the number of octets used. 2.) The handling for the <CR> encoding only applies to USSD and it is incomplete. On top of that it broke the SMS test.
* make lapd_test compile again.Harald Welte2013-07-061-69/+0
| | | | | For whatever reason two functions were present twice in the code, probably some git merge/rebase artefact?
* utils.h: we need to include utils.h for osmo_generate_backtrace()Harald Welte2013-07-061-0/+2
| | | | | this causes compiler warnings in user code ever since commit 55cf02221f0654a3f48888f3b13766b671a120f0
* Merge branch 'jolly/trx'Harald Welte2013-07-0612-84/+278
|\
| * Fix: Handle returned length by gsm_7bit_encode correctlyAndreas Eversberg2013-07-061-9/+24
| |
| * Fix encoding of last character at 7bit encoding functionAndreas Eversberg2013-07-061-0/+6
| | | | | | | | | | | | To avoid the situation where the receiving entity confuses 7 binary zero pad bits as the @ character, the carriage return or <CR> character shall be used for padding in this situation.
| * libosmogb: Add function to close NS instance without destroying itHolger Hans Peter Freyther2013-07-063-8/+17
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-22 20:28:57 +0000