summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorStefan Sperling <ssperling@sysmocom.de>2018-03-16 15:59:01 +0100
committerStefan Sperling <ssperling@sysmocom.de>2018-03-16 16:58:19 +0100
commitc9bebbd325e567333486a90b92d16ee464a4458a (patch)
tree628400f620dcf364357352b749af1634c6cbe144 /tests
parent483f386fd40bc2715a6e2c91b34e44ac1e0ae666 (diff)
add a regression test for TLV parsing with repeated IEs
Since commit bf383a1d83661af26ccd6521c49b655fb22531d4 tlv_parse() will return the first occurrence of a repeated IE. Add a test to verify this behaviour. This test passes with the current code and fails if bf383a1d83661af26ccd6521c49b655fb22531d4 is reverted. While here, fix lies in documentation about the return value of tlv_parse() and fix a typo in another comment. Change-Id: I041f38548c5e4236920991d6c681c1c1e04de9ca Related: OS#2904
Diffstat (limited to 'tests')
-rw-r--r--tests/tlv/tlv_test.c31
1 files changed, 31 insertions, 0 deletions
diff --git a/tests/tlv/tlv_test.c b/tests/tlv/tlv_test.c
index 87b002f0..2e28e548 100644
--- a/tests/tlv/tlv_test.c
+++ b/tests/tlv/tlv_test.c
@@ -245,11 +245,42 @@ static void test_tlv_shift_functions()
}
}
+/* Most GSM related protocols clearly indicate that in case of duplicate
+ * IEs, only the first occurrence shall be used, while any further occurrences
+ * shall be ignored. See e.g. 3GPP TS 24.008 Section 8.6.3 */
+static void test_tlv_repeated_ie()
+{
+ uint8_t test_data[768];
+ int i, rc;
+ const uint8_t tag = 0x1a;
+ struct tlv_parsed dec;
+ struct tlv_definition def;
+
+ memset(&def, 0, sizeof(def));
+
+ /* tag:1:255, tag:1:254, tag:1:253, ..., tag:1:3, tag:1:2, tag:1:1, tag:1:0 */
+ for (i = 0; i < ARRAY_SIZE(test_data) - 1; i += 3) {
+ test_data[i] = tag;
+ test_data[i + 1] = 1;
+ test_data[i + 2] = (uint8_t)(0xff - i/2);
+ }
+
+ def.def[tag].type = TLV_TYPE_TLV;
+
+ rc = tlv_parse(&dec, &def, &test_data[1], sizeof(test_data) - 1, tag, 0);
+ OSMO_ASSERT(rc == i/3);
+ OSMO_ASSERT(dec.lv[tag].len == 1);
+ /* Value pointer should point at first value in test data array. */
+ OSMO_ASSERT(dec.lv[tag].val == &test_data[2]);
+ OSMO_ASSERT(*dec.lv[tag].val == test_data[2]);
+}
+
int main(int argc, char **argv)
{
//osmo_init_logging(&info);
test_tlv_shift_functions();
+ test_tlv_repeated_ie();
printf("Done.\n");
return EXIT_SUCCESS;