summaryrefslogtreecommitdiffstats
path: root/tests/utils/utils_test.c
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-11-11 19:20:42 +0100
committerlaforge <laforge@osmocom.org>2019-11-23 07:58:47 +0000
commitdf22b006333d67a17b6627fba3ce468a11daa8b1 (patch)
tree23139f5413d35eb83ab5aceb4d5599cab7261193 /tests/utils/utils_test.c
parente883de54f8ab54ab84ffb75d68a5d5e100438d6f (diff)
osmo_sockaddr_str: API doc: fix 32bit addr mixup of host/network byte order
Of course both v4 and v6 addresses are kept in network byte order when represented in bytes, but when writing, I somehow must have assumed that inet_pton() returns host byte order. Fix that mixup in the API docs: osmo_sockaddr_str_from_32() and osmo_sockaddr_str_to_32() actually use network byte order. osmo_sockaddr_str_from_32n() and osmo_sockaddr_str_to_32n() actually use host byte order, though reflecting 'n' in their name. sockaddr_str_test: use hexdump instead of %x to show the osmo_sockaddr_str_to_32*() conversions so that the error becomes obvious. (Printing %x reverses the bytes again and made it look correct.) Change-Id: I3cf150cc0cc06dd36039fbde091bc71b01697322
Diffstat (limited to 'tests/utils/utils_test.c')
0 files changed, 0 insertions, 0 deletions