summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2017-10-23 19:19:13 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2017-10-24 10:51:23 +0000
commite9e9e427b78271941a25a63567fc2ec2bb9e4433 (patch)
treeac532b953deed8611ec4c6180a267e22c5838d25 /src
parent224a6dda02a2fcf11f70ac25abe9c780167649bf (diff)
vty: Fix bad use of vector_slot()
Fixes the compilation warning below: git/libosmocore/src/vty/command.c: In function ‘cmd_complete_command_real’: git/libosmocore/src/vty/command.c:1953:33: warning: comparison between pointer and zero character const ant [-Wpointer-compare] if (vector_slot(vline, index) == '\0') ^~ git/libosmocore/src/vty/command.c:37:0: git/libosmocore/include/osmocom/vty/vector.h:39:27: note: did you mean to dereference the pointer? #define vector_slot(V,I) ((V)->index[(I)]) ^ git/libosmocore/src/vty/command.c:1953:7: note: in expansion of macro ‘vector_slot’ if (vector_slot(vline, index) == '\0') ^~~~~~~~~~~ Change-Id: Iaba9e3450d68c51e16a7bda2fc0fc370992ca866
Diffstat (limited to 'src')
-rw-r--r--src/vty/command.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vty/command.c b/src/vty/command.c
index 21b26b4e..355fb5d8 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -1950,7 +1950,7 @@ static char **cmd_complete_command_real(vector vline, struct vty *vty,
/* In case of 'command \t' pattern. Do you need '?' command at
the end of the line. */
- if (vector_slot(vline, index) == '\0')
+ if (*(char *)vector_slot(vline, index) == '\0')
*status = CMD_ERR_NOTHING_TODO;
else
*status = CMD_ERR_NO_MATCH;