summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNiro Mahasinghe <niroshan@cellXica.net>2017-11-03 12:22:34 +0100
committerHarald Welte <laforge@gnumonks.org>2017-11-03 13:03:55 +0100
commit834e2ac0ead4544c207ed365151c8c898b5a949c (patch)
treee90f5141bc2c82f869ee39ddabaf5c2c081df0c6 /src
parented029dfab959bca74bd43d86922727c2047eeb4d (diff)
gsm0503_coding.c: Fix tch_efr_unreorder() of one bit
There's an error in tch_efr_unreorder() function in gsm0503_coding.c that results in increased RBER. One of the indices used by repetition bit recombining in this function doesn't match 3GPP TS 45.003 section 3.1.1.3, specifically "w(k) = s(223) for k = 231 and 232". This bug resulted in RBER even under ideal conditions, with no fading or AWGN present. Change-Id: I153da7bbc1bb3e01ed31eb5a7417e90841cfcde3
Diffstat (limited to 'src')
-rw-r--r--src/coding/gsm0503_coding.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c
index 5213dc5f..c4bdb816 100644
--- a/src/coding/gsm0503_coding.c
+++ b/src/coding/gsm0503_coding.c
@@ -1751,7 +1751,7 @@ static void tch_efr_unreorder(ubit_t *s, ubit_t *p, const ubit_t *w)
sum = s[172] + w[178] + w[179];
s[172] = (sum > 2);
memcpy(s + 174, w + 180, 50);
- sum = s[220] + w[230] + w[231];
+ sum = s[222] + w[230] + w[231];
s[222] = (sum > 2);
memcpy(s + 224, w + 232, 20);
memcpy(p, w + 252, 8);