diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2019-02-23 17:19:35 +0700 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-03-19 13:44:58 +0000 |
| commit | 54f5f4da5978662524d9a9aa106afb4a92710eb1 (patch) | |
| tree | 9b524531c8f359746f5ffc1fa37a437c81230098 /src/vty | |
| parent | 1261db15058cfa94615f26c1083bb8a38d09218b (diff) | |
vty/tdef_vty.c: drop redundant comparison
The amount of arguments is already being checked a few lines before:
/* If any arguments are missing, redirect to 'show' */
if (argc < 3)
return show_timer(self, vty, argc, argv);
so we cannot reach the expression NULL inside this statement:
group_arg = argc > 0 ? argv[0] : NULL;
Change-Id: Ice59d1a46c2080cd02060e3410706c502db4ce0b
Fixes: CID#190873 Logically dead code (DEADCODE)
Diffstat (limited to 'src/vty')
| -rw-r--r-- | src/vty/tdef_vty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vty/tdef_vty.c b/src/vty/tdef_vty.c index 04c14b9c..28de21a7 100644 --- a/src/vty/tdef_vty.c +++ b/src/vty/tdef_vty.c @@ -287,7 +287,7 @@ DEFUN(cfg_timer, cfg_timer_cmd, "DYNAMIC", "DYNAMIC") return show_timer(self, vty, argc, argv); /* If all arguments are passed, this is configuring a timer. */ - group_arg = argc > 0 ? argv[0] : NULL; + group_arg = argv[0]; timer_args = argv + 1; osmo_tdef_groups_for_each(g, global_tdef_groups) { if (strcmp(g->name, group_arg)) |