diff options
| author | Harald Welte <laforge@gnumonks.org> | 2014-05-19 11:25:46 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2014-05-19 11:25:46 +0200 |
| commit | 5b5650f3de0213a459b4184bab3ab2d0d833c4a4 (patch) | |
| tree | 430c771244ae37d7cd95960fc1781ed6aeed1213 /include/osmocom/gsm/protocol | |
| parent | c22d72cdedcea9dfd2f6286fb89d352c80808327 (diff) | |
Fix introducing osmocom speficic OML attributes
Rename NM_ATT_O_REDUCEPOWER to NM_ATT_OSMO_REDUCEPOWER, which
makes it more clear that this is an osmcoom specific attribute.
Also, we cannot simply overload 0x01 as an already defined OML
attribute. The problem is quite simple: When we use abis_nm_att_tlvdef
during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL,
which is defined as { TLV_TYPE_FIXED, 3 }.
So instead, we need to introduce a new abis_nm_osmo_att_tlvdef[],
which has to be patched into abis_nm_att_tlvdef[] by the means of
tlv_def_patch(), exactly how we do it for bs-11 and nanobts specific
attributes.
I'm using 0xfe for the attribute, as 0xfe doesn't overlap with the IPA
specific attribues (and we might want to combine/merge the 12.21 plus
IPA plus osmocom spefici attributes)
Diffstat (limited to 'include/osmocom/gsm/protocol')
| -rw-r--r-- | include/osmocom/gsm/protocol/gsm_12_21.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index b1725d54..ad0890c7 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -487,7 +487,9 @@ enum abis_nm_attr { NM_ATT_BS11_PLL_MODE = 0xfc, NM_ATT_BS11_PASSWORD = 0xfd, - NM_ATT_O_REDUCEPOWER = 0x01, + /* osmocom (osmo-bts) specific attributes, used in combination + * with the "org.osmocom" manufacturer identification */ + NM_ATT_OSMO_REDUCEPOWER = 0xfe, /* TLV_TYPE_TV */ }; #define NM_ATT_BS11_FILE_DATA NM_ATT_EVENT_TYPE |