summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2011-07-16 13:45:10 +0200
committerHarald Welte <laforge@gnumonks.org>2011-07-16 13:45:10 +0200
commitd83d1b6a0354bf53073f4936e1c3072de0202232 (patch)
tree2ed7c1851b4e57ec564aad41ed77c3abdb942787
parente43f06d14ce5c954ec1bf39546736e210cecca99 (diff)
gprs_bssgp_util.c: orig_msg == NULL is not supported
we need it for deriving the NSEI anyway. Detected by Smatch
-rw-r--r--openbsc/src/libgb/gprs_bssgp_util.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/openbsc/src/libgb/gprs_bssgp_util.c b/openbsc/src/libgb/gprs_bssgp_util.c
index b5393239..a1eb37e1 100644
--- a/openbsc/src/libgb/gprs_bssgp_util.c
+++ b/openbsc/src/libgb/gprs_bssgp_util.c
@@ -111,9 +111,8 @@ int bssgp_tx_status(uint8_t cause, uint16_t *bvci, struct msgb *orig_msg)
uint16_t _bvci = htons(*bvci);
msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &_bvci);
}
- if (orig_msg)
- msgb_tvlv_put(msg, BSSGP_IE_PDU_IN_ERROR,
- msgb_bssgp_len(orig_msg), msgb_bssgph(orig_msg));
+ msgb_tvlv_put(msg, BSSGP_IE_PDU_IN_ERROR,
+ msgb_bssgp_len(orig_msg), msgb_bssgph(orig_msg));
return gprs_ns_sendmsg(bssgp_nsi, msg);
}