diff options
| author | Max <msuraev@sysmocom.de> | 2017-01-09 14:24:03 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2017-01-10 23:28:40 +0000 |
| commit | 87218edb9acedb0eb797c47357bac472eacd8c29 (patch) | |
| tree | 19d469e67ea804b6ff09a0fd993c0658c6423801 | |
| parent | d02c8af6ccb73a18dba5d09112730246d05c187d (diff) | |
LAPD: improve logging
Log error cause and state names in case of SABM errors.
Change-Id: I2c7fa276e03f8b14ba41cc1fb6e19d0aae77d127
| -rw-r--r-- | src/gsm/lapd_core.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index fd163c83..cdd9b568 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -377,8 +377,8 @@ static int mdl_error(uint8_t cause, struct lapd_msg_ctx *lctx) struct lapd_datalink *dl = lctx->dl; struct osmo_dlsap_prim dp; - LOGP(DLLAPD, LOGL_NOTICE, "sending MDL-ERROR-IND cause %d\n", - cause); + LOGP(DLLAPD, LOGL_NOTICE, "sending MDL-ERROR-IND cause %s\n", + rsl_rlm_cause_name(cause)); osmo_prim_init(&dp.oph, 0, PRIM_MDL_ERROR, PRIM_OP_INDICATION, NULL); dp.u.error_ind.cause = cause; return dl->send_dlsap(&dp, lctx); @@ -833,7 +833,8 @@ static int lapd_rx_u(struct msgb *msg, struct lapd_msg_ctx *lctx) } if (!dl->cont_res) { LOGP(DLLAPD, LOGL_INFO, "SABM command not " - "allowed in this state\n"); + "allowed in state %s\n", + lapd_state_names[dl->state]); mdl_error(MDL_CAUSE_SABM_MF, lctx); msgb_free(msg); return 0; @@ -870,7 +871,8 @@ static int lapd_rx_u(struct msgb *msg, struct lapd_msg_ctx *lctx) /* check for contention resoultion */ if (dl->tx_hist[0].msg && dl->tx_hist[0].msg->len) { LOGP(DLLAPD, LOGL_NOTICE, "SABM not allowed " - "during contention resolution\n"); + "during contention resolution (state %s)\n", + lapd_state_names[dl->state]); mdl_error(MDL_CAUSE_SABM_INFO_NOTALL, lctx); } lapd_send_ua(lctx, length, msg->l3h); |