summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2019-01-20 13:41:26 +0100
committerHarald Welte <laforge@gnumonks.org>2019-01-22 14:53:46 +0000
commit1317771c9340a9fdc86911206cdc8719a3d2bfe6 (patch)
tree436416b7d77fd7f957258562bb1b152a2999cde8
parentd4c406a04eae0071da4fb7aecd3cb47acd0fdab6 (diff)
gsm0408_test: Fix IMEI-SV related tests to use no more than 16 digits
The IMEI-SV is speified as a 16 digit number: 14 digits of IMEI plus two digits of software version. Let's not try to feed 18 digit long numbers into our functions, as the resulting behavior is unspecified. Change-Id: I6fb85a0516dc387902ad9de4fe8c1ba82d68cae6
-rw-r--r--tests/gsm0408/gsm0408_test.c16
-rw-r--r--tests/gsm0408/gsm0408_test.ok16
2 files changed, 16 insertions, 16 deletions
diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c
index 6902e8e2..2d60b845 100644
--- a/tests/gsm0408/gsm0408_test.c
+++ b/tests/gsm0408/gsm0408_test.c
@@ -422,17 +422,17 @@ static const struct test_mid_encode_decode_test test_mid_encode_decode_tests[] =
},
{
.mi_type = GSM_MI_TYPE_IMEISV,
- .mi_str = "987654321098765432",
- .mi_name = "IMEI-SV-987654321098765432",
- .expect_mi_tlv_hex = "170a937856341290785634f2",
+ .mi_str = "9876543210987654",
+ .mi_name = "IMEI-SV-9876543210987654",
+ .expect_mi_tlv_hex = "17099378563412907856f4",
},
{
.mi_type = GSM_MI_TYPE_IMEISV,
- .mi_str = "987654321098765432",
- .mi_name = "IMEI-SV-987654321098765432",
- .expect_mi_tlv_hex = "170a937856341290785634f2",
- .str_size = 16,
- .expect_str = "987654321098765",
+ .mi_str = "9876543210987654",
+ .mi_name = "IMEI-SV-9876543210987654",
+ .expect_mi_tlv_hex = "17099378563412907856f4",
+ .str_size = 17,
+ .expect_str = "9876543210987654",
},
{
/* gsm48 treats TMSI as decimal string */
diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok
index 8f6630be..0bd101de 100644
--- a/tests/gsm0408/gsm0408_test.ok
+++ b/tests/gsm0408/gsm0408_test.ok
@@ -40,14 +40,14 @@ Testing Mobile Identity conversions
-> MI-TLV-hex='17089a78563412907856'
-> MI-str="987654321098765" rc=16
-> MI-name="IMEI-987654321098765"
-- IMEI-SV 987654321098765432
- -> MI-TLV-hex='170a937856341290785634f2'
- -> MI-str="987654321098765432" rc=19
- -> MI-name="IMEI-SV-987654321098765432"
-- IMEI-SV 987654321098765432
- -> MI-TLV-hex='170a937856341290785634f2'
- -> MI-str="987654321098765" rc=16
- -> MI-name="IMEI-SV-987654321098765432"
+- IMEI-SV 9876543210987654
+ -> MI-TLV-hex='17099378563412907856f4'
+ -> MI-str="9876543210987654" rc=17
+ -> MI-name="IMEI-SV-9876543210987654"
+- IMEI-SV 9876543210987654
+ -> MI-TLV-hex='17099378563412907856f4'
+ -> MI-str="9876543210987654" rc=17
+ -> MI-name="IMEI-SV-9876543210987654"
- TMSI 305419896
-> MI-TLV-hex='1705f412345678'
-> MI-str="305419896" rc=9