summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2018-04-17 10:40:27 +0700
committerHarald Welte <laforge@gnumonks.org>2018-04-17 12:09:48 +0000
commit07bfd565a809d4843bc13aec7dc3fac26063237c (patch)
tree3bd6406f4cf56ed1e5aa9a5f7bf9527b129e2113
parent0b2c0ecd5e283bb75765447724a9b1e26f6478b5 (diff)
protocol/gsm_04_08.h: drop incorrect GSM48_PDISC_USSD
According to the GSM TS 04.07, section 11.2.3.1.1 "Protocol discriminator", bits 1 to 4 of the first octet of a standard L3 message contain the protocol discriminator IE. Meanwhile, the GSM48_PDISC_USSD represents value 0x11, i.e. 0b10001, that requires 5 bits, and moreover it is not documented anywhere. Let's drop it. Change-Id: Ic4eb8a6db4ff1dfd535bd0c84e7acf1908422f64
-rw-r--r--include/osmocom/gsm/protocol/gsm_04_08.h1
-rw-r--r--src/gsm/gsm48.c1
2 files changed, 0 insertions, 2 deletions
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h
index 6a5fb3bb..68ba650c 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -977,7 +977,6 @@ struct gsm48_rr_status {
#define GSM48_PDISC_EXTEND 0x0e
#define GSM48_PDISC_TEST 0x0f /* as per 11.10, 04.14 */
#define GSM48_PDISC_MASK 0x0f
-#define GSM48_PDISC_USSD 0x11
extern const struct value_string gsm48_pdisc_names[];
static inline const char *gsm48_pdisc_name(uint8_t val)
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 468b2a9b..0bce1eda 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -775,7 +775,6 @@ const struct value_string gsm48_pdisc_names[] = {
{ GSM48_PDISC_LOC, "LCS" },
{ GSM48_PDISC_EXTEND, "EXTD" },
{ GSM48_PDISC_MASK, "MASK" },
- { GSM48_PDISC_USSD, "USSD" },
{ 0, NULL }
};