summaryrefslogtreecommitdiffstats
path: root/.gitreview
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2018-04-15 23:31:47 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2018-04-15 23:40:19 +0200
commitc62c93464779acddc2d516a2dd4d1317f408be8e (patch)
tree53afb188a57ddce940ca30a945d0d3178fe3c04b /.gitreview
parentdb2fa4e0d5a112adedf17948a73b481c69022e14 (diff)
test_gsm0808_enc_dec_speech_codec_with_cfg: initialize properly
The uninitialized members of enc_sc sporadically hit address sanitizer failure during gsm0808_test, like: ../../../../src/libosmocore/src/gsm/gsm0808_utils.c:187:8: runtime error: load of value 13, which is not a valid value for type '_Bool' ../../../../src/libosmocore/src/gsm/gsm0808_utils.c:191:8: runtime error: load of value 119, which is not a valid value for type '_Bool' How the test survived so long is a mystery to me; as soon as some uninitialized members would by coincidence not be zero, the test should always have failed at OSMO_ASSERT(memcmp(&enc_sc, &dec_sc, sizeof(enc_sc)) == 0). Related: OS#3148 Change-Id: Iaa20c59f624fbdc69a018cabd0f7e9c5a1389519
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions