From e7d02e2d71cd4c339b386a751f32050d33f86b89 Mon Sep 17 00:00:00 2001 From: tv Date: Sun, 8 Nov 2026 22:47:10 +0000 Subject: swarm: no SIGNATURES Signatures sent on their own (SIGNATURES, every second, to each peer not sent them yet) flooded every link: a signature made after its change left, or one that came with changes, went to every neighbour, whether or not it got the change along with its signature elsewhere. With every change of a node signed as it leaves (1217) and signatures going where their changes go (1218), none is left for them to carry: the message, its task and its traffic counter go (wire version 46). Signatures waiting for their changes are offered as before when sync messages bring them, and the changes waiting for signatures judged again with the next batch. --- src/transport/traffic.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/transport/traffic.rs') diff --git a/src/transport/traffic.rs b/src/transport/traffic.rs index e810595..b9506a9 100644 --- a/src/transport/traffic.rs +++ b/src/transport/traffic.rs @@ -57,8 +57,6 @@ pub(crate) struct ByKind { pub(crate) plumtree: Counter, /// NEIGHBOUR, NEIGHBOUR_REPLY and DISCONNECT (`swarm::hyparview`). pub(crate) hyparview: Counter, - /// SIGNATURES (`swarm::signatures`). - pub(crate) signatures: Counter, /// REFUSALS (`swarm::refusals`). pub(crate) refusals: Counter, } @@ -77,7 +75,6 @@ impl ByKind { MessageKind::Probe, MessageKind::Prune, MessageKind::Neighbour, - MessageKind::Signatures, MessageKind::Refusals, ] { let theirs = *other.get(kind); @@ -100,7 +97,6 @@ impl ByKind { MessageKind::Neighbour | MessageKind::NeighbourReply | MessageKind::Disconnect => { &self.hyparview } - MessageKind::Signatures => &self.signatures, MessageKind::Refusals => &self.refusals, } } @@ -120,7 +116,6 @@ impl ByKind { MessageKind::Neighbour | MessageKind::NeighbourReply | MessageKind::Disconnect => { &mut self.hyparview } - MessageKind::Signatures => &mut self.signatures, MessageKind::Refusals => &mut self.refusals, } } @@ -331,7 +326,6 @@ fn names(kind: MessageKind) -> (&'static str, &'static str) { MessageKind::Neighbour => ("NEIGHBOUR", "hyparview"), MessageKind::NeighbourReply => ("NEIGHBOUR_REPLY", "hyparview"), MessageKind::Disconnect => ("DISCONNECT", "hyparview"), - MessageKind::Signatures => ("SIGNATURES", "signatures"), MessageKind::Refusals => ("REFUSALS", "refusals"), } } -- cgit v1.3.1