From 59e889254b1fda2dcc8e3e6d596635d1b77f589f Mon Sep 17 00:00:00 2001 From: tv Date: Thu, 19 Nov 2026 17:44:03 +0000 Subject: transport: wire versions spoken side by side A build speaks wire versions OLDEST to VERSION and writes each node the newest both speak (wire::choose), as the node's SPEAKS says; the oldest until it says. The identity layer keeps that per address (Book::speaks): a SPEAKS from an address sets it for the address, and for every address of the node proven there, and a new address of a node takes it over. Paths encodes each message for an address in its version (Transport::encode_in; Transport::encode is the newest). So that two nodes know what the other speaks once they have proven themselves to each other, before any other message goes between them, a SPEAKS goes ahead of every WHO and ME, and WHO and ME are read in every version from 52 on (wire::PROOFS): their tags and layout never change. Without that, a node whose oldest version is past the other's couldn't read its proofs, and the two would never get to the handshake that says what each speaks. A SPEAKS naming no version this build speaks is logged as a message of another version is, naming the node to upgrade, the versions as ranges. A 0.0.1 node takes a SPEAKS from an address not yet proven for any other message from there: it drops it, and asks WHO. This build speaks 52 alone, so nothing it sends changes but the SPEAKS ahead of the proofs. A release adding a version encodes and decodes the older ones from their own, frozen, types. --- src/transport/mycelium/mod.rs | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) (limited to 'src/transport/mycelium/mod.rs') diff --git a/src/transport/mycelium/mod.rs b/src/transport/mycelium/mod.rs index f1dbe40..d5d9271 100644 --- a/src/transport/mycelium/mod.rs +++ b/src/transport/mycelium/mod.rs @@ -355,8 +355,13 @@ impl Transport for MyceliumTransport { self.lookup_pubkey(&ip).await } - fn encode(&self, peer: &str, message: &ParsedMessage) -> Result { - encode_message(peer, message) + fn encode_in( + &self, + peer: &str, + message: &ParsedMessage, + version: u8, + ) -> Result { + encode_message(peer, message, version) } async fn send_encoded(&self, message: &EncodedMessage) -> Result<()> { @@ -573,9 +578,13 @@ async fn read_capped( /// A message as the Mycelium REST API takes it (the JSON body of an outbound message). /// Also the simulator's wire format (`transport::sim`), so tests go through the same -/// encoding. -pub(crate) fn encode_message(peer: &str, message: &ParsedMessage) -> Result { - let (outbound, payload_len) = format_message(peer, message)?; +/// encoding. Its payload is in wire `version`. +pub(crate) fn encode_message( + peer: &str, + message: &ParsedMessage, + version: u8, +) -> Result { + let (outbound, payload_len) = format_message(peer, message, version)?; Ok(EncodedMessage { peer: peer.to_owned(), address: peer.to_owned(), @@ -645,12 +654,13 @@ fn parse_message(message: &InboundMessage) -> Result<(String, ParsedMessage), Tr Ok((sender, parsed)) } -/// The message for Mycelium's API, and the length of its payload. +/// The message for Mycelium's API, its payload in wire `version`, and the payload's length. fn format_message( recipient: &str, message: &ParsedMessage, + version: u8, ) -> Result<(OutboundMessage, usize), TransportError> { - let payload_bytes = wire::encode(message)?; + let payload_bytes = wire::encode_in(message, version)?; let outbound = OutboundMessage { dst: Destination { pk: recipient.to_owned(), @@ -797,7 +807,7 @@ mod tests { #[test] fn every_kind_round_trips_through_the_api_body() { for message in wire::samples() { - let encoded = encode_message("peer", &message).unwrap(); + let encoded = encode_message("peer", &message, wire::VERSION).unwrap(); assert_eq!(encoded.kind, message.kind()); let decoded = decode_message(&encoded.body).unwrap(); assert_eq!( -- cgit v1.3.1