From f24063e90d02ef76d87401d6e74cf8c9f489ff7d Mon Sep 17 00:00:00 2001 From: tv Date: Thu, 19 Nov 2026 01:48:57 +0000 Subject: fold: of a party's lists, those written under the latest version first A key a version names, stolen, could write its party's node list at a history from before the version that named the party's keys anew: written under the version before, it counted, as naming keys anew leaves a list's `since` alone, and beside the list the party wrote under the new version the lower ID won. The thief signed a few, kept the lowest, and did so again after every list the party wrote. Of a party's key sets, and of its node lists, those written under the latest version now come first, then what no other has in its history, then the lowest ID; the model alike. A list the party writes under the version that replaced the key stays, as `federation.md` says. Key sets were safe already, by their `since`; one rule serves both. This changes what counts where two of a party's lists, written under different versions, are beside each other: nodes read them alike only once all run it. Row 69 is tested (`federation_attack_69`). --- src/federation/attacks.rs | 27 +++++++++++++++++++++++++++ src/federation/fold.rs | 27 +++++++++++++++++---------- src/federation/model.rs | 15 +++++++++++---- 3 files changed, 55 insertions(+), 14 deletions(-) (limited to 'src/federation') diff --git a/src/federation/attacks.rs b/src/federation/attacks.rs index 3f44ad0..2043c19 100644 --- a/src/federation/attacks.rs +++ b/src/federation/attacks.rs @@ -1300,6 +1300,33 @@ fn federation_attack_63() { assert_eq!(pinned.state().current().hash, two.hash()); } +/// A key a version names, stolen, writes its party's node list at histories from before +/// the version that names the party's keys anew, beside the list the party writes under +/// that version, several, so that one has a lower ID: the party's counts. +#[test] +fn federation_attack_69() { + let (tv, lass, makefu) = (tv(), lass(), makefu()); + let tv_now = Party::new("tv", 4); + let mut fed = three(); + let root = fed.root(); + let on = fed.first.hash(); + let mut renamed = fed.first.after(on); + renamed.parties[0].keys_since = 1; + renamed.parties[0].keys = vec![tv_now.key_line()]; + let before = fed.take(lass.write(&[root], "home/lass/a", s("1"))); + let (_, written) = fed.pass(&[root], &lass, &renamed, on, &[&lass, &makefu]); + fed.take(tv_now.nodes(&[written], &[harness::node_id(1)])); + for n in 2..6 { + // Taken: tv's old key is named at its history. + fed.take(tv.nodes(&[before], &[harness::node_id(n)])); + } + let state = fed.store.state(); + assert_eq!( + state.nodes_of("tv", state.current()), + vec![harness::node_id(1)] + ); +} + #[test] fn federation_attack_64() { let (mut fed, head, gone, _, written) = moved(); diff --git a/src/federation/fold.rs b/src/federation/fold.rs index 3ebeebf..2e3fc56 100644 --- a/src/federation/fold.rs +++ b/src/federation/fold.rs @@ -186,28 +186,35 @@ impl State { .copied() } - /// The key set, or node list, of `party` that counts by `current`: one written under a - /// version numbered at least the `since` it gives the party's. + /// The key set, or node list, of `party` that counts by `current`: of those written + /// under a version numbered at least the `since` it gives the party's, those written + /// under the latest version, and of those the latest (`latest`). So one a stolen key + /// writes at a history from before the version that named its party's keys anew + /// replaces nothing the party wrote under that version. fn list(&self, party: &str, current: &Version, list: List) -> Option { let given = current.parties.get(party)?; let since = match list { List::Keys => given.keys_since, List::Nodes => given.nodes_since, }; - let candidates: Vec = self + let candidates: Vec<(Id, u64)> = self .signed() - .filter(|(_, signed, under)| { - signed.party == party + .filter_map(|(id, signed, under)| { + let number = self.versions.get(under)?.number; + (signed.party == party && matches!( (&signed.does, list), (Does::Keys(_), List::Keys) | (Does::Nodes(_), List::Nodes) ) - && self - .versions - .get(under) - .is_some_and(|version| version.number >= since) + && number >= since) + .then_some((*id, number)) }) - .map(|(id, _, _)| *id) + .collect(); + let latest = candidates.iter().map(|(_, number)| *number).max()?; + let candidates: Vec = candidates + .into_iter() + .filter(|(_, number)| *number == latest) + .map(|(id, _)| id) .collect(); self.latest(&candidates) } diff --git a/src/federation/model.rs b/src/federation/model.rs index 2107d9f..8cd189b 100644 --- a/src/federation/model.rs +++ b/src/federation/model.rs @@ -205,7 +205,8 @@ impl Model { }) } - /// The key set, or node list, of `party` that counts in a history by `version`. + /// The key set, or node list, of `party` that counts in a history by `version`: of + /// those written under the latest version, the latest. fn list( &self, history: &BTreeSet, @@ -219,17 +220,23 @@ impl Model { } else { given.nodes_since }; - let ids: Vec = self + let ids: Vec<(Id, u64)> = self .signed(history) - .filter(|(id, signed)| { + .filter(|(_, signed)| { signed.party == party && match signed.does { Does::Keys(_) => keys, Does::Nodes(_) => !keys, _ => false, } - && self.under(id).is_some_and(|under| under.number >= since) }) + .filter_map(|(id, _)| Some((id, self.under(&id)?.number))) + .filter(|(_, number)| *number >= since) + .collect(); + let latest = ids.iter().map(|(_, number)| *number).max()?; + let ids: Vec = ids + .into_iter() + .filter(|(_, number)| *number == latest) .map(|(id, _)| id) .collect(); self.latest(&ids) -- cgit v1.3.1