From 03744437a5ffc36fbb5e973a0ddfd6b91945b212 Mon Sep 17 00:00:00 2001 From: tv Date: Thu, 19 Nov 2026 01:48:57 +0000 Subject: federation: votes on the events proposing a checkpoint above its heads Anyone could propose a checkpoint's version again, by an event beside its heads. A node voting by itself, and a party's client, built a vote on every event proposing what it voted on, so every vote was beside the heads, and no version event written on them was taken: the checkpoint could never move the store. And the voters' rule refused it once that event was held for a while, as the heads left it out. They vote on the events proposing it that are above the heads it names (`State::proposing`), which `GET /events/counts` lists as `proposals`; where there are none, `none` says so, the node casts nothing and the client says why. The voters' rule leaves proposals and votes aside, as they lapse with the move. Row 70 is tested (`federation_attack_70`). --- docs/guides/federation/checkpoints.md | 12 ++++++------ docs/guides/federation/proposing-and-voting.md | 3 ++- docs/guides/federation/voting-by-itself.md | 10 ++++++---- 3 files changed, 14 insertions(+), 11 deletions(-) (limited to 'docs/guides') diff --git a/docs/guides/federation/checkpoints.md b/docs/guides/federation/checkpoints.md index 66f79e9..69debaf 100644 --- a/docs/guides/federation/checkpoints.md +++ b/docs/guides/federation/checkpoints.md @@ -43,12 +43,12 @@ is proposed; and it backs what it proposes. ## Backing one Back a checkpoint only where everything you held for a while before it was proposed is -among its heads, in their history, or above them: heads a proposer made up, built on -little, would take back what was written since, a key set dropping a stolen key among -it. A node voting by itself backs one only so, and so does a vote by hand through it -(`continuum-party vote … --through`). A party's client voting on its own -(`continuum-party vote`) checks no heads: check them yourself, or vote through such a -node. +among its heads, in their history, or above them, proposals and votes aside, which lapse +with the move: heads a proposer made up, built on little, would take back what was +written since, a key set dropping a stolen key among it. A node voting by itself backs one +only so, and so does a vote by hand through it (`continuum-party vote … --through`). A +party's client voting on its own (`continuum-party vote`) checks no heads: check them +yourself, or vote through such a node. * `--store-follow PARTY,…` has a node voting by itself follow those parties' votes, by default on versions that only move to a checkpoint, and still by that rule. diff --git a/docs/guides/federation/proposing-and-voting.md b/docs/guides/federation/proposing-and-voting.md index 0f303ea..2bf0dee 100644 --- a/docs/guides/federation/proposing-and-voting.md +++ b/docs/guides/federation/proposing-and-voting.md @@ -65,7 +65,8 @@ version must (its `number`, `changes`, and each `since`), whose checkpoint, wher one, names none of the heads of the current version's checkpoint, as such a version is never written. It says why it doesn't propose one otherwise. The proposal is on the current version, and its hash is the version's: the node shows it under that -hash (`proposals` in `GET /events/counts`), with the events proposing it. +hash (`proposals` in `GET /events/counts`), with the events proposing it that a vote +may build on: of a checkpoint, those above its heads. Several parties proposing the same version make one proposal. The key a party proposes and votes with is one the current version names for it, not one of its key set: the client checks that before it signs, and records nothing otherwise. diff --git a/docs/guides/federation/voting-by-itself.md b/docs/guides/federation/voting-by-itself.md index 300f60c..b88947a 100644 --- a/docs/guides/federation/voting-by-itself.md +++ b/docs/guides/federation/voting-by-itself.md @@ -61,11 +61,13 @@ no version ([`proposing-and-voting.md`](proposing-and-voting.md), [Voting](proposing-and-voting.md#voting)). And, for a version naming a checkpoint, the voters' rule: it backs one only where it changes nothing of the current version but its number, what it changes and its checkpoint, and its heads leave out nothing it held for a -while before it was proposed ([`checkpoints.md`](checkpoints.md), -[Backing one](checkpoints.md#backing-one)). A vote by hand through it keeps to the same. +while before it was proposed, proposals and votes aside +([`checkpoints.md`](checkpoints.md), [Backing one](checkpoints.md#backing-one)). A vote +by hand through it keeps to the same. -It signs its votes on the events proposing what it votes on, and its checkpoint -proposals on its heads, so that a version event may be written on them. +It signs its votes on the events proposing what it votes on, of a checkpoint those above +its heads, and its checkpoint proposals on its heads, so that a version event may be +written on them. ## Watching it -- cgit v1.3.1