From 8284fc3b99e4647098e5a97c237dd77dcd68fb65 Mon Sep 17 00:00:00 2001
From: makefu <root@pigstarter.de>
Date: Fri, 25 Apr 2014 15:54:08 +0200
Subject: make exceptions more clear

---
 titlebot/commands/undo | 10 +++++++---
 titlebot/commands/up   | 18 ++++++++++++------
 2 files changed, 19 insertions(+), 9 deletions(-)

(limited to 'titlebot/commands')

diff --git a/titlebot/commands/undo b/titlebot/commands/undo
index bebd57a..a66de67 100755
--- a/titlebot/commands/undo
+++ b/titlebot/commands/undo
@@ -16,12 +16,16 @@ except:
     undos vote of one or more entries based on .list""")
     sys.exit(1)
 voter = environ['_prefix']
+voter_name = environ['_from']
 for vote in votes:
     try:
         vote = int(vote)
-        del(db[vote]['votes'][voter] )
-        print("undid vote by %s for #%d" %(environ['_from'],vote))
+        if not voter in db[vote]['votes']:
+            print("%s, you never voted for '%s'!"%(voter_name,db[vote]['title']))
+        else:
+            del(db[vote]['votes'][voter] )
+            print("%s undid vote for '%s'" %(voter_name,db[vote]['title'] ))
     except:
-        print("undo voting for #%s failed" %vote)
+        print("%s undo voting for #%d failed" %(voter_name,vote))
 
 poll.save_db(f,db)
diff --git a/titlebot/commands/up b/titlebot/commands/up
index c9de122..0a48bdb 100755
--- a/titlebot/commands/up
+++ b/titlebot/commands/up
@@ -9,19 +9,25 @@ import poll
 f = 'suggestions.json'
 db = poll.load_db(f)
 votes = []
-try:
-    votes = sys.argv[1:]
-except:
+votes = sys.argv[1:]
+if not votes:
     print("""usage: up number (...)
     upvotes one or more entries based on .list""")
     sys.exit(1)
 
 voter = environ['_prefix']
+voter_name =environ['_from']
 for vote in votes:
     try:
         vote = int(vote)
-        db[vote]['votes'][voter] = 1
+        if vote < 0:
+            raise Exception()
+        if voter in db[vote]['votes']:
+            print("%s, you already have voted for '%s'"%(voter_name,db[vote]['title']) )
+        else:
+            db[vote]['votes'][voter] = 1
+            print("%s voted for '%s'"%(voter_name,db[vote]['title']))
     except:
-        print("voting for #%s failed" %vote)
-print("Thanks for your votes %s"%environ['_from'])
+        print("%s, voting for #%s failed" %(voter_name,vote))
+
 poll.save_db(f,db)
-- 
cgit v1.2.3


From c35e62e336afdcfc0123ff29ec99266a29a6e812 Mon Sep 17 00:00:00 2001
From: makefu <root@pigstarter.de>
Date: Fri, 25 Apr 2014 16:34:34 +0200
Subject: add highest for titlebot

---
 titlebot/commands/highest | 22 ++++++++++++++++++++++
 titlebot/commands/list    |  4 ++--
 2 files changed, 24 insertions(+), 2 deletions(-)
 create mode 100755 titlebot/commands/highest

(limited to 'titlebot/commands')

diff --git a/titlebot/commands/highest b/titlebot/commands/highest
new file mode 100755
index 0000000..5ac9ba9
--- /dev/null
+++ b/titlebot/commands/highest
@@ -0,0 +1,22 @@
+#!/usr/bin/env python3
+import json
+from os import environ
+import sys
+import os
+import poll
+
+f = 'suggestions.json'
+title=" ".join(sys.argv[1:])
+db = poll.load_db(f)
+limit = int(sys.argv[1]) if len(sys.argv) > 1 else 1
+num = 1 
+# stolen from http://stackoverflow.com/questions/9647202/ordinal-numbers-replacement
+suffixes = ["th", "st", "nd", "rd", ] + ["th"] * 16
+
+for entry in poll.sort_by_votes(db):
+    suffixed_num = str(num) + suffixes[num % 100]
+    print("%s: '%s' (%d votes)" %
+            (suffixed_num,entry['title'],sum(entry['votes'].values())))
+    num = num + 1
+    if num > limit:
+        sys.exit(0)
diff --git a/titlebot/commands/list b/titlebot/commands/list
index 3a29919..cee4b8a 100755
--- a/titlebot/commands/list
+++ b/titlebot/commands/list
@@ -17,11 +17,11 @@ if len(sys.argv) > 1 and ("-h" in sys.argv[1]  or "usage" == sys.argv[1]):
 if len(sys.argv) > 1 and ("votes" in sys.argv[1]):
     use = poll.sort_by_votes(db)
 elif len(sys.argv) > 1 and ("age" in sys.argv[1]) or len(sys.argv) == 1:
-    pass
+    use = db
 else:
     print("unknown sorting method")
     sys.exit(1)
 
-for entry in poll.sort_by_votes(db):
+for entry in use:
     print("#%d %s (votes: %d)" %
             (db.index(entry),entry['title'],sum(entry['votes'].values())))
-- 
cgit v1.2.3


From 8ba1237707cf9da18344d2725e5d867f93dcd3c3 Mon Sep 17 00:00:00 2001
From: makefu <root@pigstarter.de>
Date: Fri, 25 Apr 2014 16:57:32 +0200
Subject: fix ranking in highest

watch out for same ranking of things
---
 titlebot/commands/highest | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

(limited to 'titlebot/commands')

diff --git a/titlebot/commands/highest b/titlebot/commands/highest
index 5ac9ba9..d0408ac 100755
--- a/titlebot/commands/highest
+++ b/titlebot/commands/highest
@@ -8,15 +8,23 @@ import poll
 f = 'suggestions.json'
 title=" ".join(sys.argv[1:])
 db = poll.load_db(f)
+# only print the last N values (default 1)
 limit = int(sys.argv[1]) if len(sys.argv) > 1 else 1
-num = 1 
+num =  0
+last_vote = 9001
 # stolen from http://stackoverflow.com/questions/9647202/ordinal-numbers-replacement
 suffixes = ["th", "st", "nd", "rd", ] + ["th"] * 16
 
 for entry in poll.sort_by_votes(db):
+    # if two entries have the same number of upvotes, do not increment the rank
+    current_vote = sum(entry['votes'].values())
+    if current_vote < last_vote:
+        num = num + 1
+    last_vote = current_vote
+    # exit if we are above the limit
+    if num > limit:
+        sys.exit(0)
+    
     suffixed_num = str(num) + suffixes[num % 100]
     print("%s: '%s' (%d votes)" %
             (suffixed_num,entry['title'],sum(entry['votes'].values())))
-    num = num + 1
-    if num > limit:
-        sys.exit(0)
-- 
cgit v1.2.3